[Extensions UI] Initially disabled OK button for extension install prompts.

chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_install_dialog_view.h"
 
 #include <utility>
 
 #include "base/macros.h"
+#include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_icon_manager.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_install_prompt_test_helper.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
@@ skipping 144 matching lines @@
 
     views::Widget* modal_dialog = views::DialogDelegate::CreateDialogWidget(
         dialog.release(), nullptr,
         platform_util::GetViewForWindow(
             browser()->window()->GetNativeWindow()));
     modal_dialog->Show();
 
     return delegate_view;
   }
 
+  base::OneShotTimer timer;

[Devlin, 2017/03/23 01:25:30]

needed?

[Ackerman, 2017/03/31 22:03:22]

Nope, removed.

+
  private:
   DISALLOW_COPY_AND_ASSIGN(ExtensionInstallDialogViewTest);
 };
 
 // Verifies that the delegate is notified when the user selects to accept or
 // cancel the install.
 IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogViewTest, NotifyDelegate) {
   {
     // User presses install.
     ExtensionInstallPromptTestHelper helper;
@@ skipping 11 matching lines @@
   {
     // Dialog is closed without the user explicitly choosing to proceed or
     // cancel.
     ExtensionInstallPromptTestHelper helper;
     views::DialogDelegateView* delegate_view = CreateAndShowPrompt(&helper);
     delegate_view->GetWidget()->Close();
     // TODO(devlin): Should this be ABORTED?
     EXPECT_EQ(ExtensionInstallPrompt::Result::USER_CANCELED, helper.result());
   }
 }
+
+// Verifies that the "Add extension" button is disabled initally, but enabled
+// after a short time delay.
+IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogViewTest, DelayInstalls) {
+  ExtensionInstallDialogView::SetInstallDelayForTesting(0);
+  ExtensionInstallPromptTestHelper helper;
+  views::DialogDelegateView* delegate_view = CreateAndShowPrompt(&helper);
+
+  // Check initial button states.
+  ASSERT_FALSE(delegate_view->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));

[Devlin, 2017/03/23 01:25:30]

nit: we can make these EXPECTs instead of ASSERTs

[Ackerman, 2017/03/31 22:03:22]

Done.

+  ASSERT_TRUE(delegate_view->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
+
+  // Check OK button state after timeout to verify that it is enabled.
+  base::RunLoop().RunUntilIdle();
+  ASSERT_TRUE(delegate_view->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+  delegate_view->Close();
+}