[Extensions UI] Initially disabled OK button for extension install prompts.

chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h
index ff284af7fab045a9ba9e5e3e9ad684ba1f9ef317..7406d4d6db0ee34677c09c41103572ea08440151 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h
@@ -47,13 +47,13 @@ class ExtensionInstallViewDelegate {
 
   // Present only in the install dialogs with webstore data (inline and
   // external).
-  IBOutlet NSBox* warningsSeparator_; // Only when there are permissions.
+  IBOutlet NSBox* warningsSeparator_;  // Only when there are permissions.
   IBOutlet NSView* ratingStars_;
   IBOutlet NSTextField* ratingCountField_;
   IBOutlet NSTextField* userCountField_;
   IBOutlet NSButton* storeLinkButton_;
 
-  Profile* profile_; // weak
+  Profile* profile_;                   // weak
   content::PageNavigator* navigator_;  // weak
   ExtensionInstallViewDelegate* delegate_;  // weak
   std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt_;
@@ -79,10 +79,13 @@ class ExtensionInstallViewDelegate {
             navigator:(content::PageNavigator*)navigator
              delegate:(ExtensionInstallViewDelegate*)delegate
                prompt:(std::unique_ptr<ExtensionInstallPrompt::Prompt>)prompt;
-- (IBAction)storeLinkClicked:(id)sender; // Callback for "View details" link.
+- (IBAction)storeLinkClicked:(id)sender;  // Callback for "View details" link.
 - (IBAction)cancel:(id)sender;
 - (IBAction)ok:(id)sender;
 
+// Change the time delay of enabling the install button for testing purposes.
++ (void)setInstallDelayForTesting:(NSTimeInterval)time_delay_in_s;

[Devlin, 2017/03/23 01:25:29]

nit: Cocoa uses camelCaseSyntax

[Devlin, 2017/03/23 01:25:29]

I've also seen us use a separate interface for testing, e.g.
@interface ExtensionInstallViewController(TestingAPI)

Avi will know which is best practice (if either is preferable).

[Avi (use Gerrit), 2017/03/23 02:32:32]

I've seen the (TestingAPI) too, but naming it with ForTesting means that the
presubmit will catch misuse. Or do both!

BTW don't do "time_delay_in_s". It's not "in s", it's an NSTimeInterval.

[Ackerman, 2017/03/31 22:03:21]

Noted. I will used both.

+
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_EXTENSIONS_EXTENSION_INSTALL_VIEW_CONTROLLER_H_