[Extensions UI] Initially disabled OK button for extension install prompts.

chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_EXTENSIONS_EXTENSION_INSTALL_VIEW_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_EXTENSIONS_EXTENSION_INSTALL_VIEW_CONTROLLER_H_
 
 #include <vector>
 
 #import <Cocoa/Cocoa.h>
@@ skipping 29 matching lines @@
   IBOutlet NSTextField* titleField_;
   IBOutlet NSTextField* itemsField_;
   IBOutlet NSButton* cancelButton_;
   IBOutlet NSButton* okButton_;
 
   // Present only when the dialog has permission warnings issues to display.
   IBOutlet NSOutlineView* outlineView_;
 
   // Present only in the install dialogs with webstore data (inline and
   // external).
-  IBOutlet NSBox* warningsSeparator_; // Only when there are permissions.
+  IBOutlet NSBox* warningsSeparator_;  // Only when there are permissions.
   IBOutlet NSView* ratingStars_;
   IBOutlet NSTextField* ratingCountField_;
   IBOutlet NSTextField* userCountField_;
   IBOutlet NSButton* storeLinkButton_;
 
-  Profile* profile_; // weak
+  Profile* profile_;                   // weak
   content::PageNavigator* navigator_;  // weak
   ExtensionInstallViewDelegate* delegate_;  // weak
   std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt_;
 
   base::scoped_nsobject<NSArray> warnings_;
   BOOL isComputingRowHeight_;
 }
 
 // For unit test use only.
 @property(nonatomic, readonly) NSImageView* iconView;
 @property(nonatomic, readonly) NSTextField* titleField;
 @property(nonatomic, readonly) NSTextField* itemsField;
 @property(nonatomic, readonly) NSButton* cancelButton;
 @property(nonatomic, readonly) NSButton* okButton;
 @property(nonatomic, readonly) NSOutlineView* outlineView;
 @property(nonatomic, readonly) NSBox* warningsSeparator;
 @property(nonatomic, readonly) NSView* ratingStars;
 @property(nonatomic, readonly) NSTextField* ratingCountField;
 @property(nonatomic, readonly) NSTextField* userCountField;
 @property(nonatomic, readonly) NSButton* storeLinkButton;
 
 - (id)initWithProfile:(Profile*)profile
             navigator:(content::PageNavigator*)navigator
              delegate:(ExtensionInstallViewDelegate*)delegate
                prompt:(std::unique_ptr<ExtensionInstallPrompt::Prompt>)prompt;
-- (IBAction)storeLinkClicked:(id)sender; // Callback for "View details" link.
+- (IBAction)storeLinkClicked:(id)sender;  // Callback for "View details" link.
 - (IBAction)cancel:(id)sender;
 - (IBAction)ok:(id)sender;
 
+// Change the time delay of enabling the install button for testing purposes.
++ (void)setInstallDelayForTesting:(NSTimeInterval)time_delay_in_s;

[Devlin, 2017/03/23 01:25:29]

nit: Cocoa uses camelCaseSyntax

[Devlin, 2017/03/23 01:25:29]

I've also seen us use a separate interface for testing, e.g.
@interface ExtensionInstallViewController(TestingAPI)

Avi will know which is best practice (if either is preferable).

[Avi (use Gerrit), 2017/03/23 02:32:32]

I've seen the (TestingAPI) too, but naming it with ForTesting means that the
presubmit will catch misuse. Or do both!

BTW don't do "time_delay_in_s". It's not "in s", it's an NSTimeInterval.

[Ackerman, 2017/03/31 22:03:21]

Noted. I will used both.

+
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_EXTENSIONS_EXTENSION_INSTALL_VIEW_CONTROLLER_H_