Build tools revision updated.

Build tools revision updated.

Protobuf dependency check is added to build tools and revision updated after that.

BUG=684383
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2716353002
Cr-Commit-Position: refs/heads/master@{#453203}
Committed: https://chromium.googlesource.com/chromium/src/+/0dcd76d7f39b82db6f216041f0e7751b0b98a306

[Ramin Halavati, 2017-02-27 12:54:10]

rhalavati@chromium.org changed reviewers:
+ msramek@chromium.org

[Ramin Halavati, 2017-02-27 12:54:10]

Martin,

Please land this as well regarding https://codereview.chromium.org/2691943002/

[msramek, 2017-02-27 12:58:11]

LGTM. This is back in the Chromium project, so you should be able to just CQ it.

[Ramin Halavati, 2017-02-27 12:58:38]

The CQ bit was checked by rhalavati@chromium.org

[commit-bot: I haz the power, 2017-02-27 12:58:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 13:57:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488200318697750, "parent_rev":
"974a148dff6919ce3bfe8036ca7f47af99bfa78e", "commit_rev":
"0dcd76d7f39b82db6f216041f0e7751b0b98a306"}

[commit-bot: I haz the power, 2017-02-27 13:58:08]

Description was changed from

==========
Build tools revision updated.

Protobuf dependency check is added to build tools and revision updated after
that.

BUG=684383
TBR=brettw@chromium.org
==========

to

==========
Build tools revision updated.

Protobuf dependency check is added to build tools and revision updated after
that.

BUG=684383
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2716353002
Cr-Commit-Position: refs/heads/master@{#453203}
Committed:
https://chromium.googlesource.com/chromium/src/+/0dcd76d7f39b82db6f216041f0e7...
==========

[commit-bot: I haz the power, 2017-02-27 13:58:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0dcd76d7f39b82db6f216041f0e7...

[Nico, 2017-02-28 00:21:52]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-02-28 00:21:52]

When rolling buildtools, please include a list of included changes always. Had
you done this, you'd noticed that there's a clang-format roll in this too, and
that had been reverted since it brought in a broken clang-format that you
brought in again. In fairness, we should've reverted that upstream in
buildtools, but we didn't.

[Ramin Halavati, 2017-02-28 09:54:24]

On 2017/02/28 00:21:52, Nico wrote:
> When rolling buildtools, please include a list of included changes always. Had
> you done this, you'd noticed that there's a clang-format roll in this too, and
> that had been reverted since it brought in a broken clang-format that you
> brought in again. In fairness, we should've reverted that upstream in
> buildtools, but we didn't.

I am sorry for the problem.
Could you please elaborate on what I had to do, and now that you have rolled it
back and corrected the clang-format's problem, what is the correct approach to
roll it again.

[Ramin Halavati, 2017-03-07 12:30:44]

On 2017/02/28 09:54:24, Ramin Halavati wrote:
> On 2017/02/28 00:21:52, Nico wrote:
> > When rolling buildtools, please include a list of included changes always.
Had
> > you done this, you'd noticed that there's a clang-format roll in this too,
and
> > that had been reverted since it brought in a broken clang-format that you
> > brought in again. In fairness, we should've reverted that upstream in
> > buildtools, but we didn't.
> 
> I am sorry for the problem.
> Could you please elaborate on what I had to do, and now that you have rolled
it
> back and corrected the clang-format's problem, what is the correct approach to
> roll it again.

Hi Nico,

I wondered if you could guide me towards correct applying this CL.

Bests,
Ramin

[Nico, 2017-03-07 13:08:07]

I didn't revert it, I rolled forward with a fix. This change is still in.
This was just a plea for a better cl description next time.

On Mar 7, 2017 7:30 AM, <rhalavati@chromium.org> wrote:

> On 2017/02/28 09:54:24, Ramin Halavati wrote:
> > On 2017/02/28 00:21:52, Nico wrote:
> > > When rolling buildtools, please include a list of included changes
> always.
> Had
> > > you done this, you'd noticed that there's a clang-format roll in this
> too,
> and
> > > that had been reverted since it brought in a broken clang-format that
> you
> > > brought in again. In fairness, we should've reverted that upstream in
> > > buildtools, but we didn't.
> >
> > I am sorry for the problem.
> > Could you please elaborate on what I had to do, and now that you have
> rolled
> it
> > back and corrected the clang-format's problem, what is the correct
> approach to
> > roll it again.
>
> Hi Nico,
>
> I wondered if you could guide me towards correct applying this CL.
>
> Bests,
> Ramin
>
> https://codereview.chromium.org/2716353002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.