Issue 271633002: Unloaded font segment should not affect primaryFontData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271633002: Unloaded font segment should not affect primaryFontData (Closed)

Created:
6 years, 7 months ago by Kunihiko Sakamoto

Modified:
6 years, 7 months ago

Reviewers:
dglazkov, eae

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Unloaded font segment should not affect primaryFontData This patch fixes a bug where SVG fonts are not rendered correctly when SVG font is part of a segmented font face that has unloaded font faces. SegmentedFontData::isLoadingFallback() returns true for such segmented font face, so FontFallbackList::primaryFontData() returned next available font in the fallback list. After this patch, FontFallbackList::primaryFontData() returns the first font data with space character loaded. BUG=369633 TEST=svg/custom/svg-fonts-unloaded-segment.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173859

Patch Set 1 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -4 lines)			Patch
A	LayoutTests/svg/custom/svg-fonts-unloaded-segment.html	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/custom/svg-fonts-unloaded-segment-expected.html	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	Source/platform/fonts/FontFallbackList.cpp	View	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Kunihiko Sakamoto

The CQ bit was checked by ksakamoto@chromium.org

6 years, 7 months ago (2014-05-12 08:43:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/271633002/30001

6 years, 7 months ago (2014-05-12 08:43:42 UTC) #4

Message was sent while issue was closed.

Change committed as 173859

Expand Messages | Collapse Messages