Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2716293003: Abstract ShareActivity Class (Closed)
Patch Set: Removed Availability Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index a186f8746a97f51605c1c50b95f4a9a92d1cab05..b2535903945263f93e0b514b6872367b845871f5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -105,6 +105,7 @@ import org.chromium.chrome.browser.preferences.PreferencesLauncher;
import org.chromium.chrome.browser.printing.PrintShareActivity;
import org.chromium.chrome.browser.printing.TabPrinter;
import org.chromium.chrome.browser.share.OptionalShareTargetsManager;
+import org.chromium.chrome.browser.share.ShareActivity;
import org.chromium.chrome.browser.share.ShareHelper;
import org.chromium.chrome.browser.snackbar.BottomContainer;
import org.chromium.chrome.browser.snackbar.DataReductionPromoSnackbarController;
@@ -1160,12 +1161,12 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
final Tab currentTab = getActivityTab();
if (currentTab == null) return;
- List<Class<? extends Activity>> classesToEnable = new ArrayList<>(2);
+ List<Class<? extends ShareActivity>> classesToEnable = new ArrayList<>(2);
- if (PrintShareActivity.printingIsEnabled(currentTab)) {
+ if (PrintShareActivity.featureIsAvailable(currentTab)) {
classesToEnable.add(PrintShareActivity.class);
}
- if (PhysicalWebShareActivity.sharingIsEnabled(currentTab)) {
+ if (PhysicalWebShareActivity.featureIsAvailable()) {
classesToEnable.add(PhysicalWebShareActivity.class);
}

Powered by Google App Engine
This is Rietveld 408576698