Abstract ShareActivity Class

chrome/android/java/src/org/chromium/chrome/browser/share/ShareActivity.java

Index: chrome/android/java/src/org/chromium/chrome/browser/share/ShareActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/share/ShareActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/share/ShareActivity.java
new file mode 100644
index 0000000000000000000000000000000000000000..782a81eed95032089f03db3279d0b30e5ed8c119
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/share/ShareActivity.java
@@ -0,0 +1,67 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.share;
+
+import android.app.Activity;
+import android.content.Intent;
+import android.os.Bundle;
+import android.support.v7.app.AppCompatActivity;
+
+import org.chromium.base.ApplicationStatus;
+import org.chromium.chrome.browser.ChromeActivity;
+import org.chromium.chrome.browser.util.IntentUtils;
+
+import java.lang.ref.WeakReference;
+import java.util.List;
+
+/**
+ * {@code ShareActivity} is the base class for share options, which
+ * are activities that are shown in the share chooser. Activities subclassing
+ * ShareActivity override featureIsEnabled, and handleShareAction.
+ */
+public abstract class ShareActivity extends AppCompatActivity {
+    @Override
+    protected void onCreate(Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);
+
+        try {
+            Intent intent = getIntent();
+            if (intent == null) return;
+            if (!Intent.ACTION_SEND.equals(intent.getAction())) return;
+            if (!IntentUtils.safeHasExtra(intent, ShareHelper.EXTRA_TASK_ID)) return;
+            handleShareAction();
+        } finally {
+            finish();
+        }
+    }
+
+    /**
+     * Returns the ChromeActivity that called the share intent picker.
+     */
+    protected ChromeActivity getTriggeringActivity() {
+        int triggeringTaskId =
+                IntentUtils.safeGetIntExtra(getIntent(), ShareHelper.EXTRA_TASK_ID, 0);
+        List<WeakReference<Activity>> activities = ApplicationStatus.getRunningActivities();
+        ChromeActivity triggeringActivity = null;
+        for (int i = 0; i < activities.size(); i++) {
+            Activity activity = activities.get(i).get();
+            if (activity == null) continue;
+
+            // Since the share intent is triggered without NEW_TASK or NEW_DOCUMENT, the task ID

[Ted C, 2017/03/02 21:21:26]

I made this comment invalid in one of my earlier patches in the area, can you
remove it now that you're moving this so its lies don't continue :-)

[iankc, 2017/03/02 21:33:26]

Done.

+            // of this activity will match that of the triggering activity.
+            if (activity.getTaskId() == triggeringTaskId && activity instanceof ChromeActivity) {
+                return (ChromeActivity) activity;
+            }
+        }
+        return null;
+    }
+
+    /**
+     * Completes the share action.
+     * Override this activity to implement desired share functionality.  The activity
+     * will be destroyed immediately after this method is called.
+     */
+    protected abstract void handleShareAction();

[Ted C, 2017/03/02 21:21:26]

Should we pass the triggering activity here?  That can return null so I think it
would make sense to get the triggering activity in onCreate, if null, return and
only in the non-null case call into handleShareAction.  Then the method can be
private as well.

[iankc, 2017/03/02 21:33:26]

Done.

+}