Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: components/omnibox/browser/omnibox_field_trial.h

Issue 2716273004: Invert description and URL for experimental zero suggest suggestions. (Closed)
Patch Set: Make title/url swap an independent feature Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_field_trial.h
diff --git a/components/omnibox/browser/omnibox_field_trial.h b/components/omnibox/browser/omnibox_field_trial.h
index 6c7ca25b0c1faa810425f4f20c9e85d3aa803cf6..67119897d2f640dbebbaa08beedb4cead19c3d2a 100644
--- a/components/omnibox/browser/omnibox_field_trial.h
+++ b/components/omnibox/browser/omnibox_field_trial.h
@@ -14,7 +14,7 @@
#include "base/macros.h"
#include "components/metrics/proto/omnibox_event.pb.h"
-#include "components/metrics/proto/omnibox_input_type.pb.h"
+#include "components/omnibox/browser/autocomplete_input.h"
#include "components/omnibox/browser/autocomplete_match_type.h"
namespace base {
@@ -378,7 +378,7 @@ class OmniboxFieldTrial {
// Normally the URL is displayed more prominently. Returns NEVER_EMPHASIZE
// if the experiment isn't active.
static EmphasizeTitlesCondition GetEmphasizeTitlesConditionForInput(
- metrics::OmniboxInputType::Type input_type);
+ const AutocompleteInput& input);
// ---------------------------------------------------------
// For PhysicalWebProvider related experiments.
@@ -404,8 +404,8 @@ class OmniboxFieldTrial {
// For experiment redirecting zero suggest requests to a service provided by
// the Chrome team.
- // Returns whether the user is in the field trial which redirects zero suggest
- // requests to the service provided by the Chrome team.
+ // Returns true whether the user is in the field trial which redirects zero
+ // suggest requests to the service provided by the Chrome team.
static bool InZeroSuggestRedirectToChromeFieldTrial();
// Returns a string representing the address of the server where the zero
@@ -420,6 +420,10 @@ class OmniboxFieldTrial {
// request URL.
static std::string ZeroSuggestRedirectToChromeAdditionalFields();
+ // Returns true whether the user is in the field trial which swaps the title
+ // and the URL for zero suggest suggestions.
+ static bool InZeroSuggestSwapTitleAndUrlFieldTrial();
+
// ---------------------------------------------------------
// Exposed publicly for the sake of unittests.
static const char kBundledExperimentFieldTrialName[];

Powered by Google App Engine
This is Rietveld 408576698