Invert description and URL for experimental zero suggest suggestions.

components/omnibox/browser/omnibox_field_trial.cc

Index: components/omnibox/browser/omnibox_field_trial.cc
diff --git a/components/omnibox/browser/omnibox_field_trial.cc b/components/omnibox/browser/omnibox_field_trial.cc
index 935e2b1aa6e7617b04ad5416c91dd032fedd7e90..e34d8a5dd5271a693eab324e892985e9f7e855ad 100644
--- a/components/omnibox/browser/omnibox_field_trial.cc
+++ b/components/omnibox/browser/omnibox_field_trial.cc
@@ -523,10 +523,15 @@ int OmniboxFieldTrial::KeywordScoreForSufficientlyCompleteMatch() {
 
 OmniboxFieldTrial::EmphasizeTitlesCondition
 OmniboxFieldTrial::GetEmphasizeTitlesConditionForInput(
-    metrics::OmniboxInputType::Type input_type) {
+    const AutocompleteInput& input) {
   // Look up the parameter named kEmphasizeTitlesRule + ":" + input_type,

[Mark P, 2017/02/28 22:24:28]

nit: This comment no longer applies to the code.  Move it to the code it's near
and add a new comment.

[gcomanici, 2017/03/01 02:56:28]

I added a comment for the condition I added, and kept the comment for the rest.

   // find its value, and return that value as an enum.  If the parameter
   // isn't redefined, fall back to the generic rule kEmphasizeTitlesRule + ":*"
+  metrics::OmniboxInputType::Type input_type = input.type();

[Mark P, 2017/02/28 22:24:28]

nit: it's alias isn't significantly shorter or more clear than what it's
aliasing.  Please remove.

[gcomanici, 2017/03/01 02:56:28]

Done.

+  if (input.from_omnibox_focus() &&
+      OmniboxFieldTrial::InZeroSuggestSwapTitleAndUrlFieldTrial()) {

[Mark P, 2017/02/28 22:24:28]

nit: just test directly to see if the feature is enabled.

(The function is necessary.)

[gcomanici, 2017/03/01 02:56:28]

Done.

+    return EMPHASIZE_WHEN_NONEMPTY;
+  }
   std::string value_str(variations::GetVariationParamValue(
       kBundledExperimentFieldTrialName,
       std::string(kEmphasizeTitlesRule) + "_" +
@@ -606,6 +611,11 @@ std::string OmniboxFieldTrial::ZeroSuggestRedirectToChromeAdditionalFields() {
       kZeroSuggestRedirectToChromeAdditionalFieldsParam);
 }
 
+// static
+bool OmniboxFieldTrial::InZeroSuggestSwapTitleAndUrlFieldTrial() {
+  return base::FeatureList::IsEnabled(features::kZeroSuggestSwapTitleAndUrl);
+}
+
 const char OmniboxFieldTrial::kBundledExperimentFieldTrialName[] =
     "OmniboxBundledExperimentV1";
 const char OmniboxFieldTrial::kDisableProvidersRule[] = "DisableProviders";