Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2716233002: MD Settings: add "More actions..." text to all vertical 3-dot menus (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add "More actions..." text to all vertical 3-dot menus R=hcarmona@chromium.org BUG=693373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2716233002 Cr-Commit-Position: refs/heads/master@{#453262} Committed: https://chromium.googlesource.com/chromium/src/+/76a6942d9ee1972d4ab6676d93625774940230a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M chrome/app/settings_strings.grdp View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_url_entry.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_printers_list.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_entry.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/protocol_handlers.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/usb_devices.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Beam
3 years, 9 months ago (2017-02-27 05:38:38 UTC) #3
hcarmona
lgtm
3 years, 9 months ago (2017-02-27 17:47:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716233002/1
3 years, 9 months ago (2017-02-27 18:09:54 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 18:16:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76a6942d9ee1972d4ab6676d9362...

Powered by Google App Engine
This is Rietveld 408576698