Issue 271623002: Revert "Arm64: Ensure that csp is always aligned to 16 byte values even if jssp is not." and "Arm64…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271623002: Revert "Arm64: Ensure that csp is always aligned to 16 byte values even if jssp is not." and "Arm64… (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer

Modified:
6 years, 7 months ago

Reviewers:
rmcilroy

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Arm64: Ensure that csp is always aligned to 16 byte values even if jssp is not." and "Arm64: Fix check errors on Arm64 debug after r21177.". This reverts commit r21177 and r21179 for breaking the arm64 build. TBR=rmcilroy@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21184

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -184 lines)			Patch
M	src/arm64/code-stubs-arm64.cc	View	2 chunks	+6 lines, -15 lines	0 comments	Download
M	src/arm64/cpu-arm64.h	View	3 chunks	+11 lines, -14 lines	0 comments	Download
M	src/arm64/cpu-arm64.cc	View	2 chunks	+2 lines, -19 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.h	View	2 chunks	+6 lines, -16 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.cc	View	15 chunks	+31 lines, -25 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64-inl.h	View	4 chunks	+24 lines, -51 lines	0 comments	Download
M	src/arm64/regexp-macro-assembler-arm64.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/builtins.cc	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	src/cpu.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cpu.cc	View	2 chunks	+1 line, -27 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/v8globals.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/test-code-stubs-arm64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 7 months ago (2014-05-07 06:41:02 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r21184 (tree was closed).

Expand Messages | Collapse Messages