Fix paint property under-invalidation of CSS clip on resize

Fix paint property under-invalidation of CSS clip on resize

BUG=694875
TEST=*PaintPropertyTreeUpdateTest.CSSClipDependingOnSize*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2716203003
Cr-Commit-Position: refs/heads/master@{#453404}
Committed: https://chromium.googlesource.com/chromium/src/+/4f2629181c9c12fcca25f436910afbb2b5789bb6

[Xianzhu, 2017-02-27 20:47:54]

Description was changed from

==========
Fix paint property under-invalidation of CSS clip on resize

BUG=694875
TEST=*PaintPropertyTreeUpdateTest.CSSClipDependingOnSize*
==========

to

==========
Fix paint property under-invalidation of CSS clip on resize

BUG=694875
TEST=*PaintPropertyTreeUpdateTest.CSSClipDependingOnSize*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-02-27 20:48:09]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2017-02-27 21:53:11]

LGTM

[Xianzhu, 2017-02-27 21:55:14]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-02-27 21:55:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 00:08:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488232514952050, "parent_rev":
"c72ce2a231f22abab37a62e41f15a79545ba4cce", "commit_rev":
"4f2629181c9c12fcca25f436910afbb2b5789bb6"}

[commit-bot: I haz the power, 2017-02-28 00:09:27]

Description was changed from

==========
Fix paint property under-invalidation of CSS clip on resize

BUG=694875
TEST=*PaintPropertyTreeUpdateTest.CSSClipDependingOnSize*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix paint property under-invalidation of CSS clip on resize

BUG=694875
TEST=*PaintPropertyTreeUpdateTest.CSSClipDependingOnSize*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2716203003
Cr-Commit-Position: refs/heads/master@{#453404}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f2629181c9c12fcca25f436910a...
==========

[commit-bot: I haz the power, 2017-02-28 00:09:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f2629181c9c12fcca25f436910a...

[chrishtr, 2017-02-28 00:11:18]

chrishtr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2017-02-28 00:11:18]

https://codereview.chromium.org/2716203003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2716203003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1738: } else if (hasClip())
{
Is this needed for clip-path as well?

[Xianzhu, 2017-02-28 00:17:20]

https://codereview.chromium.org/2716203003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2716203003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1738: } else if (hasClip())
{
On 2017/02/28 00:11:18, chrishtr wrote:
> Is this needed for clip-path as well?

We seem not to support clip-path in paint property tree for now. Should we?

[chrishtr, 2017-02-28 00:19:47]

On 2017/02/28 at 00:17:20, wangxianzhu wrote:
>
https://codereview.chromium.org/2716203003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):
> 
>
https://codereview.chromium.org/2716203003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutBox.cpp:1738: } else if
(hasClip()) {
> On 2017/02/28 00:11:18, chrishtr wrote:
> > Is this needed for clip-path as well?
> 
> We seem not to support clip-path in paint property tree for now. Should we?

clip-path is a form of masking. trchen is going to work on it soon. But since
it's similar to mask and CSS mask is implemented, I think we need
a conditional for masking here?

[chrishtr, 2017-02-28 00:19:53]

chrishtr@chromium.org changed reviewers:
+ trchen@chromium.org

[Xianzhu, 2017-02-28 00:32:09]

Filed crbug.com/696811 for masks (including clip-paths).

[trchen, 2017-02-28 00:43:28]

https://codereview.chromium.org/2716203003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2716203003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1738: } else if (hasClip())
{
On 2017/02/28 00:17:20, Xianzhu wrote:
> On 2017/02/28 00:11:18, chrishtr wrote:
> > Is this needed for clip-path as well?
> 
> We seem not to support clip-path in paint property tree for now. Should we?

Thanks for the heads up! Yea, I think this will be needed for clip-path as well,
and definitely is needed for masks. (Because masks implicitly create a clip,
which is implemented by clip node.)

I think it makes sense to match
LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize().
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...