Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2716173002: [merge-m57] Anchor the first run bubble off the location bar icon's ImageView. (Closed)

Created:
3 years, 9 months ago by tapted
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[merge-m57] Anchor the first run bubble off the location bar icon's ImageView. Currently anchors off the whole icon, which might be the centre of a rectangular security chip. Use LocationBarView::GetSecurityBubbleAnchorView(), same as other bubbles. The FirstRunBubble constructor already offsets the anchor by LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET, like other bubbles anchoring off the ImageView. BUG=690361 Review-Url: https://codereview.chromium.org/2705323004 Cr-Commit-Position: refs/heads/master@{#452728} (cherry picked from commit 96752f23762f0ad4320bb4aa0737857b5fe582f3) Review-Url: https://codereview.chromium.org/2716173002 . Cr-Commit-Position: refs/branch-heads/2987@{#690} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/fbe3e139935ab2dc813669ae8ac2d2de8ed3715f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tapted
3 years, 9 months ago (2017-02-26 23:02:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fbe3e139935ab2dc813669ae8ac2d2de8ed3715f.

Powered by Google App Engine
This is Rietveld 408576698