Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2716153005: Merge 57: Set capture_time_ms using rtc::TimeMicros() (Closed)

Created:
3 years, 9 months ago by emircan
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Set capture_time_ms using rtc::TimeMicros() capture_time_ms should be based on system clock and setting it by using camera capture timestamp may cause sync issue, i.e. the bug below. Set this field using rtc::TimeMicros(). BUG=695909, webrtc:7045 Review-Url: https://codereview.chromium.org/2692853009 Cr-Commit-Position: refs/heads/master@{#451171} (cherry picked from commit 1dd4ccf354c3286647e35ed6e02c36de695901fc) NOTRY=true NOPRESUBMIT=true TBR=mcasas@chromium.org,nisse@chromium.org,holmer@chromium.org Review-Url: https://codereview.chromium.org/2716153005 Cr-Commit-Position: refs/branch-heads/2987@{#703} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/ecd17b7797c37dc21837cd7ee268f3e9474e3107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M content/renderer/media/gpu/rtc_video_encoder.cc View 3 chunks +21 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716153005/1
3 years, 9 months ago (2017-02-27 21:46:09 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 21:50:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ecd17b7797c37dc21837cd7ee268...

Powered by Google App Engine
This is Rietveld 408576698