Removed FrameHost::chromeClient()

Removed FrameHost::chromeClient()

Removed the FrameHost::chromeClient() method, and redirected calls to
Page::chromeClient() using FrameHost's Page reference (or directly on
the Page object if it is available). Also removed some now-redundant
FrameHost includes, and added a TODO to remove Page::frameHost().

This is part of the work to merge FrameHost back into Page.

BUG=691794
Review-Url: https://codereview.chromium.org/2716153003
Cr-Commit-Position: refs/heads/master@{#453485}
Committed: https://chromium.googlesource.com/chromium/src/+/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0

[sashab, 2017-02-27 02:13:19]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[sashab, 2017-02-27 06:07:56]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 06:08:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 06:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 06:10:02]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sashab, 2017-02-27 06:38:06]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 06:38:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-02-27 07:06:49]

sashab@chromium.org changed reviewers:
+ slangley@chromium.org

[haraken, 2017-02-27 07:53:23]

LGTM

[slangley, 2017-02-27 08:32:34]

slangley@chromium.org changed reviewers:
+ haraken@chromium.org

[slangley, 2017-02-27 08:32:35]

lgtm

https://codereview.chromium.org/2716153003/diff/20002/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/BrowserControls.cpp (right):

https://codereview.chromium.org/2716153003/diff/20002/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/BrowserControls.cpp:8: #include
"core/frame/FrameHost.h"
should be a vertical space between system & user headers I think.

The examples have spaces anyway:
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

https://codereview.chromium.org/2716153003/diff/20002/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/forms/InputType.cpp (right):

https://codereview.chromium.org/2716153003/diff/20002/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/forms/InputType.cpp:32: #include
"bindings/core/v8/ExceptionMessages.h"
As above

[commit-bot: I haz the power, 2017-02-27 08:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 08:36:43]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-02-28 01:13:59]

Thanks for the feedback stu! Done.

[sashab, 2017-02-28 01:14:02]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-02-28 01:14:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, slangley@chromium.org
Link to the patchset: https://codereview.chromium.org/2716153003/#ps50001
(title: "Small feedback")

[commit-bot: I haz the power, 2017-02-28 01:14:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 03:40:45]

CQ is committing da patch.

Bot data: {"patchset_id": 50001, "attempt_start_ts": 1488244442813750,
"parent_rev": "2f2a6b849bcee8b531b45effa22de6ed03dc33d7", "commit_rev":
"d1291c79d5f9b2e34bb9c15c32d869f44111f8e0"}

[commit-bot: I haz the power, 2017-02-28 03:41:24]

Description was changed from

==========
Removed FrameHost::chromeClient()

Removed the FrameHost::chromeClient() method, and redirected calls to
Page::chromeClient() using FrameHost's Page reference (or directly on
the Page object if it is available). Also removed some now-redundant
FrameHost includes, and added a TODO to remove Page::frameHost().

This is part of the work to merge FrameHost back into Page.

BUG=691794
==========

to

==========
Removed FrameHost::chromeClient()

Removed the FrameHost::chromeClient() method, and redirected calls to
Page::chromeClient() using FrameHost's Page reference (or directly on
the Page object if it is available). Also removed some now-redundant
FrameHost includes, and added a TODO to remove Page::frameHost().

This is part of the work to merge FrameHost back into Page.

BUG=691794

Review-Url: https://codereview.chromium.org/2716153003
Cr-Commit-Position: refs/heads/master@{#453485}
Committed:
https://chromium.googlesource.com/chromium/src/+/d1291c79d5f9b2e34bb9c15c32d8...
==========

[commit-bot: I haz the power, 2017-02-28 03:41:26]

Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/d1291c79d5f9b2e34bb9c15c32d8...