Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2715993002:
[Kiosk] Do not allow to exit the fullscreen mode in kiosk mode. (Closed)
|
Created:
3 years, 10 months ago by xdai1 Modified:
3 years, 10 months ago Reviewers:
Mr4D (OOO till 08-26) CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Kiosk] Do not allow to exit the fullscreen mode in kiosk mode.
When running a kiosk app in tablet mode, touch on the top of the screen
can cause the title bar appear, which allows the app to be exited. We
should prevent this happening in kiosk mode.
BUG=614771
Review-Url: https://codereview.chromium.org/2715993002
Cr-Commit-Position: refs/heads/master@{#452972}
Committed: https://chromium.googlesource.com/chromium/src/+/b75b8d38e4d7575ba77e578710e711f1c6d2e581
Patch Set 1 #
Total comments: 2
Messages
Total messages: 17 (11 generated)
xdai@chromium.org changed reviewers: + skuhne@chromium.org
skuhne@, could you help review this CL please? Thanks!
The CQ bit was checked by xdai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2715993002/diff/1/ash/common/wm/maximize_mode... File ash/common/wm/maximize_mode/maximize_mode_event_handler.cc (right): https://codereview.chromium.org/2715993002/diff/1/ash/common/wm/maximize_mode... ash/common/wm/maximize_mode/maximize_mode_event_handler.cc:62: LoginStatus::ARC_KIOSK_APP) { Hmm. You know that this has only impact in tablet mode? Does Kiosk run in that mode? if so - this looks good. Otherwise it might be the wrong location.
Description was changed from ========== [Kiosk] Do not allow to exit the fullscreen mode in kiosk mode. BUG=614771 ========== to ========== [Kiosk] Do not allow to exit the fullscreen mode in kiosk mode. When running a kiosk app in touch mode, touch on the top of the screen can cause the title bar appear, which allows the app to be existed. We should prevent this happening in kiosk mode. BUG=614771 ==========
skuhne@, please take another look, thanks! https://codereview.chromium.org/2715993002/diff/1/ash/common/wm/maximize_mode... File ash/common/wm/maximize_mode/maximize_mode_event_handler.cc (right): https://codereview.chromium.org/2715993002/diff/1/ash/common/wm/maximize_mode... ash/common/wm/maximize_mode/maximize_mode_event_handler.cc:62: LoginStatus::ARC_KIOSK_APP) { On 2017/02/24 22:33:57, Mr4D wrote: > Hmm. You know that this has only impact in tablet mode? Does Kiosk run in that > mode? if so - this looks good. Otherwise it might be the wrong location. Yes, this only happens in tablet mode. See the repro steps in the bug 614771. I also modified the bug description to be more clear.
lgtm
Description was changed from ========== [Kiosk] Do not allow to exit the fullscreen mode in kiosk mode. When running a kiosk app in touch mode, touch on the top of the screen can cause the title bar appear, which allows the app to be existed. We should prevent this happening in kiosk mode. BUG=614771 ========== to ========== [Kiosk] Do not allow to exit the fullscreen mode in kiosk mode. When running a kiosk app in touch mode, touch on the top of the screen can cause the title bar appear, which allows the app to be exited. We should prevent this happening in kiosk mode. BUG=614771 ==========
Description was changed from ========== [Kiosk] Do not allow to exit the fullscreen mode in kiosk mode. When running a kiosk app in touch mode, touch on the top of the screen can cause the title bar appear, which allows the app to be exited. We should prevent this happening in kiosk mode. BUG=614771 ========== to ========== [Kiosk] Do not allow to exit the fullscreen mode in kiosk mode. When running a kiosk app in tablet mode, touch on the top of the screen can cause the title bar appear, which allows the app to be exited. We should prevent this happening in kiosk mode. BUG=614771 ==========
The CQ bit was checked by xdai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487976307305820, "parent_rev":
"84358c00a81eab2e2ccc5485fbfe44ffc50307dc", "commit_rev":
"b75b8d38e4d7575ba77e578710e711f1c6d2e581"}
Message was sent while issue was closed.
Description was changed from ========== [Kiosk] Do not allow to exit the fullscreen mode in kiosk mode. When running a kiosk app in tablet mode, touch on the top of the screen can cause the title bar appear, which allows the app to be exited. We should prevent this happening in kiosk mode. BUG=614771 ========== to ========== [Kiosk] Do not allow to exit the fullscreen mode in kiosk mode. When running a kiosk app in tablet mode, touch on the top of the screen can cause the title bar appear, which allows the app to be exited. We should prevent this happening in kiosk mode. BUG=614771 Review-Url: https://codereview.chromium.org/2715993002 Cr-Commit-Position: refs/heads/master@{#452972} Committed: https://chromium.googlesource.com/chromium/src/+/b75b8d38e4d7575ba77e578710e7... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b75b8d38e4d7575ba77e578710e7... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
