Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2715983002: aura-mus: Remove dead code. (Closed)

Created:
3 years, 10 months ago by sadrul
Modified:
3 years, 9 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, creis+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aura-mus: Remove dead code. ui::Window no longer exists. Remove code that deals with it. BUG=none Review-Url: https://codereview.chromium.org/2715983002 Cr-Commit-Position: refs/heads/master@{#453299} Committed: https://chromium.googlesource.com/chromium/src/+/cb3da9c98f24a2fe73a40d490548e1a9acf1df1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -66 lines) Patch
M chrome/browser/ui/views/chrome_web_dialog_view.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/aura/mus/mus_util.h View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/aura/mus/mus_util.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M ui/views/widget/widget.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
sadrul
3 years, 10 months ago (2017-02-25 01:43:17 UTC) #6
sky
LGTM
3 years, 9 months ago (2017-02-27 16:32:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715983002/1
3 years, 9 months ago (2017-02-27 17:22:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/373590)
3 years, 9 months ago (2017-02-27 17:30:43 UTC) #11
sadrul
+avi@ for content/browser/web_contents (will TBR since trivial change to remove reference to now-deleted header)
3 years, 9 months ago (2017-02-27 18:54:46 UTC) #13
Avi (use Gerrit)
lgtm
3 years, 9 months ago (2017-02-27 18:55:41 UTC) #14
sadrul
On 2017/02/27 18:55:41, Avi wrote: > lgtm Thanks! :)
3 years, 9 months ago (2017-02-27 18:56:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715983002/1
3 years, 9 months ago (2017-02-27 18:56:52 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 19:39:24 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb3da9c98f24a2fe73a40d490548...

Powered by Google App Engine
This is Rietveld 408576698