MD Settings/Options: add equivalent logs for "time until interactive"

MD Settings/Options: add equivalent logs for "time until interactive"

This is so we can test the speed of both pages in the wild

R=dpapad@chromium.org,asvitkine@chromium.org
BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2715933004
Cr-Commit-Position: refs/heads/master@{#454764}
Committed: https://chromium.googlesource.com/chromium/src/+/a53c8f8f7a4c7f0f73eaa321909aefee7639bb35

[Dan Beam, 2017-02-24 21:09:15]

Description was changed from

==========
MD Settings/Options: add equivalent logs for "time until interactive"

This is so we can test the speed of both pages in the wild

R=dpapad@chromium.org,asvitkine@chromium.org
BUG=597347
==========

to

==========
MD Settings/Options: add equivalent logs for "time until interactive"

This is so we can test the speed of both pages in the wild

R=dpapad@chromium.org,asvitkine@chromium.org
BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-02-24 21:10:02]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 21:11:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-02-24 21:37:38]

asvitkine@ for histograms.xml
dpapad@ for rest

[commit-bot: I haz the power, 2017-02-25 00:18:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:18:35]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-02-25 01:04:08]

https://codereview.chromium.org/2715933004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_ui/settings_ui.js (right):

https://codereview.chromium.org/2715933004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.js:164:
['Settings.TimeUntilInteractive', window.performance.now()]);
How do we differentiate between old VS new timings? Do we care about the case
where
 1) a user with enabled MD Settings goes to chrome://settings-frame?
 2) a user with disabled MD Settings goes to chrome://md-settings?

Would those mess up the metrics by recording both metrics in the same bucket?

[Alexei Svitkine (slow), 2017-02-27 15:50:18]

histograms lgtm

[Dan Beam, 2017-03-04 02:36:05]

wdyt?

https://codereview.chromium.org/2715933004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_ui/settings_ui.js (right):

https://codereview.chromium.org/2715933004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.js:164:
['Settings.TimeUntilInteractive', window.performance.now()]);
On 2017/02/25 01:04:08, dpapad wrote:
> How do we differentiate between old VS new timings? Do we care about the case
> where
>  1) a user with enabled MD Settings goes to chrome://settings-frame?
>  2) a user with disabled MD Settings goes to chrome://md-settings?
> 
> Would those mess up the metrics by recording both metrics in the same bucket?

i really don't care, to be honest.

in the case of ChromeOS, we really should be comparing against settings-frame. 
that's how users get to settings.

on the case of desktop, we could filter only those on 'chrome://settings', but
like barely anybody does anything other than the typical flow.

i really don't think we need to care about differentiating md-settings nor
settings-frame

[dpapad, 2017-03-04 02:54:05]

LGTM

https://codereview.chromium.org/2715933004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_ui/settings_ui.js (right):

https://codereview.chromium.org/2715933004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.js:164:
['Settings.TimeUntilInteractive', window.performance.now()]);
On 2017/03/04 at 02:36:05, Dan Beam wrote:
> On 2017/02/25 01:04:08, dpapad wrote:
> > How do we differentiate between old VS new timings? Do we care about the
case
> > where
> >  1) a user with enabled MD Settings goes to chrome://settings-frame?
> >  2) a user with disabled MD Settings goes to chrome://md-settings?
> > 
> > Would those mess up the metrics by recording both metrics in the same
bucket?
> 
> i really don't care, to be honest.
> 
> in the case of ChromeOS, we really should be comparing against settings-frame.
 that's how users get to settings.
> 
> on the case of desktop, we could filter only those on 'chrome://settings', but
like barely anybody does anything other than the typical flow.
> 
> i really don't think we need to care about differentiating md-settings nor
settings-frame

SGTM. I did not know we can filter by URL.

[Dan Beam, 2017-03-04 03:27:26]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-03-04 03:27:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 05:45:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488598046335070, "parent_rev":
"76905b16d9f5ba9533a7e8d41724fcd383fa4d37", "commit_rev":
"a53c8f8f7a4c7f0f73eaa321909aefee7639bb35"}

[commit-bot: I haz the power, 2017-03-04 05:46:58]

Description was changed from

==========
MD Settings/Options: add equivalent logs for "time until interactive"

This is so we can test the speed of both pages in the wild

R=dpapad@chromium.org,asvitkine@chromium.org
BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings/Options: add equivalent logs for "time until interactive"

This is so we can test the speed of both pages in the wild

R=dpapad@chromium.org,asvitkine@chromium.org
BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2715933004
Cr-Commit-Position: refs/heads/master@{#454764}
Committed:
https://chromium.googlesource.com/chromium/src/+/a53c8f8f7a4c7f0f73eaa321909a...
==========

[commit-bot: I haz the power, 2017-03-04 05:46:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a53c8f8f7a4c7f0f73eaa321909a...