Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2715913002: Introduce rootEditableElementOrTreeScopeRootNodeOf() as replacement of FrameSelection member (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce rootEditableElementOrTreeScopeRootNodeOf() as replacement of FrameSelection member This patch Introduces |rootEditableElementOrTreeScopeRootNodeOf()| as replacement of |FrameSelection::rootEditableElementOrTreeScopeRootNode()| to hoist |computeVisibleSelectionInDOMTreeDeprecated()| and simplify |FrameSelection| for improving code health. BUG=695776 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2715913002 Cr-Commit-Position: refs/heads/master@{#452816} Committed: https://chromium.googlesource.com/chromium/src/+/4130eea2c32a5d3e0014ee9de21c16b2a55bb09f

Patch Set 1 : 2017-02-24T16:18:33 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
yosin_UTC9
PTAL It seems bots are in trouble due by infra issue.
3 years, 10 months ago (2017-02-24 09:06:28 UTC) #9
tkent
lgtm
3 years, 10 months ago (2017-02-24 14:10:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715913002/1
3 years, 10 months ago (2017-02-24 14:11:22 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 14:16:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4130eea2c32a5d3e0014ee9de21c...

Powered by Google App Engine
This is Rietveld 408576698