Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushError.cpp

Issue 2715903002: Re-design Unsubscribe and getPermissionStatus mojo interfaces. (Closed)
Patch Set: Re-design Unsubscribe and getPermissionStatus mojo interfaces. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/push_messaging/PushError.cpp
diff --git a/third_party/WebKit/Source/modules/push_messaging/PushError.cpp b/third_party/WebKit/Source/modules/push_messaging/PushError.cpp
index 7d7dc8996ef5b198cd6bd76e9669f6ff1ed93279..4600be6fc22293fcab4d10fa96c37debac4fb0a9 100644
--- a/third_party/WebKit/Source/modules/push_messaging/PushError.cpp
+++ b/third_party/WebKit/Source/modules/push_messaging/PushError.cpp
@@ -19,14 +19,15 @@ DOMException* PushError::take(ScriptPromiseResolver*,
return DOMException::create(InvalidStateError, webError.message);
case WebPushError::ErrorTypeNetwork:
return DOMException::create(NetworkError, webError.message);
+ case WebPushError::ErrorTypeNone:
+ NOTREACHED();
+ return DOMException::create(UnknownError, webError.message);
case WebPushError::ErrorTypeNotAllowed:
return DOMException::create(NotAllowedError, webError.message);
case WebPushError::ErrorTypeNotFound:
return DOMException::create(NotFoundError, webError.message);
case WebPushError::ErrorTypeNotSupported:
return DOMException::create(NotSupportedError, webError.message);
- case WebPushError::ErrorTypeUnknown:
- return DOMException::create(UnknownError, webError.message);
}
NOTREACHED();
return DOMException::create(UnknownError);

Powered by Google App Engine
This is Rietveld 408576698