Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: content/common/push_messaging_param_traits.cc

Issue 2715903002: Re-design Unsubscribe and getPermissionStatus mojo interfaces. (Closed)
Patch Set: Re-design Unsubscribe and getPermissionStatus mojo interfaces. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/push_messaging.mojom ('k') | third_party/WebKit/Source/modules/push_messaging/PushError.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/push_messaging_param_traits.cc
diff --git a/content/common/push_messaging_param_traits.cc b/content/common/push_messaging_param_traits.cc
index 74b9bc5c77bda6483fb05efa37323a70dbb4d741..d336d0c4ac6c0c530914bda70c7ef78bbae22a49 100644
--- a/content/common/push_messaging_param_traits.cc
+++ b/content/common/push_messaging_param_traits.cc
@@ -117,6 +117,11 @@ static_assert(blink::WebPushError::ErrorType::ErrorTypeNetwork ==
content::mojom::PushErrorType::NETWORK),
"PushErrorType enums must match, NETWORK");
+static_assert(blink::WebPushError::ErrorType::ErrorTypeNone ==
+ static_cast<blink::WebPushError::ErrorType>(
+ content::mojom::PushErrorType::NONE),
+ "PushErrorType enums must match, NONE");
+
static_assert(blink::WebPushError::ErrorType::ErrorTypeNotAllowed ==
static_cast<blink::WebPushError::ErrorType>(
content::mojom::PushErrorType::NOT_ALLOWED),
@@ -132,11 +137,6 @@ static_assert(blink::WebPushError::ErrorType::ErrorTypeNotSupported ==
content::mojom::PushErrorType::NOT_SUPPORTED),
"PushErrorType enums must match, NOT_SUPPORTED");
-static_assert(blink::WebPushError::ErrorType::ErrorTypeUnknown ==
- static_cast<blink::WebPushError::ErrorType>(
- content::mojom::PushErrorType::UNKNOWN),
- "PushErrorType enums must match, UNKNOWN");
-
static_assert(blink::WebPushError::ErrorType::ErrorTypeInvalidState ==
static_cast<blink::WebPushError::ErrorType>(
content::mojom::PushErrorType::INVALID_STATE),
@@ -270,7 +270,7 @@ EnumTraits<content::mojom::PushErrorType, blink::WebPushError::ErrorType>::
}
NOTREACHED();
- return content::mojom::PushErrorType::UNKNOWN;
+ return content::mojom::PushErrorType::ABORT;
}
// static
« no previous file with comments | « content/common/push_messaging.mojom ('k') | third_party/WebKit/Source/modules/push_messaging/PushError.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698