[inspector] move coverage related methods to profiler

[inspector] move coverage related methods to profiler

R=dgozman@chromium.org, pfeldman@chromium.org
BUG=v8:5808
Review-Url: https://codereview.chromium.org/2715833003
Cr-Commit-Position: refs/heads/master@{#43426}
Committed: https://chromium.googlesource.com/v8/v8/+/64a563c97f84c474a3f8b9a6b02c68ec1728cfee

[kozy, 2017-02-24 00:31:44]

Description was changed from

==========
[inspector] move coverage related methods to profiler

These methods are available regardless is Profiler enabled or not.

R=dgozman@chromium.org, pfeldman@chromium.org
BUG=v8:5808
==========

to

==========
[inspector] move coverage related methods to profiler

These methods are available regardless is Profiler enabled or not.

R=dgozman@chromium.org, pfeldman@chromium.org
BUG=v8:5808
==========

[kozy, 2017-02-24 00:32:31]

After offline discussion we decided that Profiler domain is better place for
coverage related methods.

Dmitry and Pavel, please take a look.

[kozy, 2017-02-24 01:33:59]

Description was changed from

==========
[inspector] move coverage related methods to profiler

These methods are available regardless is Profiler enabled or not.

R=dgozman@chromium.org, pfeldman@chromium.org
BUG=v8:5808
==========

to

==========
[inspector] move coverage related methods to profiler

R=dgozman@chromium.org, pfeldman@chromium.org
BUG=v8:5808
==========

[kozy, 2017-02-24 01:37:16]

kozyatinskiy@chromium.org changed reviewers:
+ alph@chromium.org

[kozy, 2017-02-24 01:37:17]

+Alexey for v8-profiler-agent refactoring review.

[dgozman, 2017-02-24 02:07:57]

looks good, deferring to alph

[alph, 2017-02-24 03:12:56]

lgtm

https://codereview.chromium.org/2715833003/diff/40001/src/inspector/v8-profil...
File src/inspector/v8-profiler-agent-impl.cc (right):

https://codereview.chromium.org/2715833003/diff/40001/src/inspector/v8-profil...
src/inspector/v8-profiler-agent-impl.cc:367: m_profiler->SetIdle(m_idle);
Do you really need that? I bet m_idle is always false here.

[kozy, 2017-02-24 03:15:41]

https://codereview.chromium.org/2715833003/diff/40001/src/inspector/v8-profil...
File src/inspector/v8-profiler-agent-impl.cc (right):

https://codereview.chromium.org/2715833003/diff/40001/src/inspector/v8-profil...
src/inspector/v8-profiler-agent-impl.cc:367: m_profiler->SetIdle(m_idle);
On 2017/02/24 03:12:56, alph wrote:
> Do you really need that? I bet m_idle is always false here.

I'm not sure. I'll try to get rid of this flag in follow up CL to not mix
refactoring with semantic changes.

[kozy, 2017-02-24 03:16:03]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 03:16:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 03:38:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 03:38:04]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-02-24 05:50:09]

Pavel or Dmitry, please take a look, I need owner lgtm for js_protocol.json.

[Yang, 2017-02-24 05:53:39]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2017-02-24 05:53:40]

lgtm. thanks!

[kozy, 2017-02-24 05:55:25]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 05:55:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 06:38:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 06:38:51]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-02-24 19:41:58]

lgtm

[kozy, 2017-02-24 19:42:13]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-24 19:42:14]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2715833003/#ps50010
(title: ""true" -> true")

[commit-bot: I haz the power, 2017-02-24 19:42:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:45:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 19:45:10]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/35471)

[kozy, 2017-02-24 19:54:16]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-24 19:54:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, alph@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2715833003/#ps70001
(title: "rebased")

[commit-bot: I haz the power, 2017-02-24 19:54:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 20:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:12:39]

Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/21613)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[kozy, 2017-02-24 20:13:28]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:13:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 20:19:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:19:30]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[kozy, 2017-02-24 20:20:53]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:21:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 20:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:26:11]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[kozy, 2017-02-24 20:49:37]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:49:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 20:56:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:56:40]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[kozy, 2017-02-24 22:02:31]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-24 22:02:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 22:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 22:06:18]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/21621)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[kozy, 2017-02-24 23:33:18]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-24 23:33:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 23:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 23:51:36]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/18060)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[kozy, 2017-02-25 00:05:46]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 00:05:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:44:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:44:58]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-02-25 02:43:05]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-25 02:43:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 02:44:57]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1487990585473510,
"parent_rev": "6b7650f03944238afd67274cec634cc511524562", "commit_rev":
"64a563c97f84c474a3f8b9a6b02c68ec1728cfee"}

[commit-bot: I haz the power, 2017-02-25 02:45:03]

Description was changed from

==========
[inspector] move coverage related methods to profiler

R=dgozman@chromium.org, pfeldman@chromium.org
BUG=v8:5808
==========

to

==========
[inspector] move coverage related methods to profiler

R=dgozman@chromium.org, pfeldman@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2715833003
Cr-Commit-Position: refs/heads/master@{#43426}
Committed:
https://chromium.googlesource.com/v8/v8/+/64a563c97f84c474a3f8b9a6b02c68ec172...
==========

[commit-bot: I haz the power, 2017-02-25 02:45:04]

Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/v8/v8/+/64a563c97f84c474a3f8b9a6b02c68ec172...