Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2715823003: Web MIDI: extract manufacturer names on some devices (Closed)

Created:
3 years, 9 months ago by Takashi Toyoshima
Modified:
3 years, 9 months ago
Reviewers:
yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: extract manufacturer names on some devices This does not help us in most cases on Windows 10, but let me introduce the same code with the legacy backend. BUG=497573, 617086, 672793 Review-Url: https://codereview.chromium.org/2715823003 Cr-Commit-Position: refs/heads/master@{#453884} Committed: https://chromium.googlesource.com/chromium/src/+/d4acd504da2e43ca94a5fe97d14ec01e0f15a69d

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M media/midi/dynamically_initialized_midi_manager_win.cc View 1 2 7 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Takashi Toyoshima
ptal
3 years, 9 months ago (2017-02-27 08:13:06 UTC) #4
yhirano
lgtm
3 years, 9 months ago (2017-03-01 01:03:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715823003/20001
3 years, 9 months ago (2017-03-01 03:26:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715823003/40001
3 years, 9 months ago (2017-03-01 07:22:03 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 08:41:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d4acd504da2e43ca94a5fe97d14e...

Powered by Google App Engine
This is Rietveld 408576698