Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2715793004: Migrate Number constants and undefined to C++ (Closed)

Created:
3 years, 10 months ago by rongjie
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate Number constants and undefined to C++ BUG=v8:6005 R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2715793004 Cr-Commit-Position: refs/heads/master@{#43438} Committed: https://chromium.googlesource.com/v8/v8/+/024c4ff0dedfa7f3d163b4e9093673c185ad9e50

Patch Set 1 #

Patch Set 2 : Reuse string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -34 lines) Patch
M AUTHORS View 2 chunks +2 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 3 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rongjie
3 years, 10 months ago (2017-02-24 12:49:17 UTC) #1
Benedikt Meurer
Thanks for the patch. For V8 issues, make sure to add v8: in front of ...
3 years, 10 months ago (2017-02-25 08:25:25 UTC) #3
rongjie
On 2017/02/25 08:25:25, Benedikt Meurer wrote: > Thanks for the patch. For V8 issues, make ...
3 years, 10 months ago (2017-02-25 08:30:31 UTC) #4
Benedikt Meurer
On 2017/02/25 08:30:31, rongjie wrote: > On 2017/02/25 08:25:25, Benedikt Meurer wrote: > > Thanks ...
3 years, 9 months ago (2017-02-27 07:27:55 UTC) #5
rongjie
I already signed it.
3 years, 9 months ago (2017-02-27 07:38:29 UTC) #6
Benedikt Meurer
Perfect, thanks. LGTM!
3 years, 9 months ago (2017-02-27 07:51:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715793004/20001
3 years, 9 months ago (2017-02-27 07:57:52 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 08:20:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/024c4ff0dedfa7f3d163b4e9093673c185a...

Powered by Google App Engine
This is Rietveld 408576698