Change mock canvases to paint into SkCanvas

Change mock canvases to paint into SkCanvas

To simplify interfaces, cc::PaintCanvas doesn't want to support onDrawX
style overrides while painting.  To avoid this, change test code that
paints into mock canvases and tries to detect what has been drawn to
paint into a PaintCanvas originally and play that recorded result
back into an SkCanvas afterwards.

In the future, when PaintRecord is more introspectable by test code
and isn't just providing an SkPicture, then test code could just look
at the PaintRecord directly.

This code all works right now because cc::PaintCanvas is a typedef to
SkCanvas, but as soon as they become separate types then this code
will no longer work.

BUG=671433
Review-Url: https://codereview.chromium.org/2715793002
Cr-Commit-Position: refs/heads/master@{#453060}
Committed: https://chromium.googlesource.com/chromium/src/+/26abaa05f21dc00bd9f089e3aea037891c6d903a

[enne (OOO), 2017-02-23 19:05:36]

enne@chromium.org changed reviewers:
+ pdr@chromium.org, sadrul@chromium.org

[enne (OOO), 2017-02-23 19:06:01]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 19:06:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 19:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 19:11:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[enne (OOO), 2017-02-23 19:15:20]

Description was changed from

==========
Change mock canvases to paint into SkCanvas

To simplify interfaces, cc::PaintCanvas doesn't want to support onDrawX
style overrides while painting.  To avoid this, change test code that
paints into mock canvases and tries to detect what has been drawn to
paint into a PaintCanvas originally and play that recorded result
back into an SkCanvas afterwards.

In the future, when PaintRecord is more introspectable by test code
and isn't just providing an SkPicture, then test code could just look
at the PaintRecord directly.

BUG=671433
==========

to

==========
Change mock canvases to paint into SkCanvas

To simplify interfaces, cc::PaintCanvas doesn't want to support onDrawX
style overrides while painting.  To avoid this, change test code that
paints into mock canvases and tries to detect what has been drawn to
paint into a PaintCanvas originally and play that recorded result
back into an SkCanvas afterwards.

In the future, when PaintRecord is more introspectable by test code
and isn't just providing an SkPicture, then test code could just look
at the PaintRecord directly.

This code all works right now because cc::PaintCanvas is a typedef to
SkCanvas, but as soon as they become separate types then this code
will no longer work.

BUG=671433
==========

[enne (OOO), 2017-02-23 19:20:03]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[pdr., 2017-02-23 19:20:40]

On 2017/02/23 at 19:06:13, enne wrote:
> 

LGTM

[commit-bot: I haz the power, 2017-02-23 19:20:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 21:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 21:13:55]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-02-24 19:51:03]

enne@chromium.org changed reviewers:
+ tapted@chromium.org

[enne (OOO), 2017-02-24 19:51:15]

+tapted as alternate sadrul

[sadrul, 2017-02-25 01:46:27]

lgtm

[enne (OOO), 2017-02-25 01:53:37]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2017-02-25 01:53:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 03:50:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487987617130400,
"parent_rev": "5f9a48e44f1257972cb83947355c7298555ccc94", "commit_rev":
"26abaa05f21dc00bd9f089e3aea037891c6d903a"}

[commit-bot: I haz the power, 2017-02-25 03:50:56]

Description was changed from

==========
Change mock canvases to paint into SkCanvas

To simplify interfaces, cc::PaintCanvas doesn't want to support onDrawX
style overrides while painting.  To avoid this, change test code that
paints into mock canvases and tries to detect what has been drawn to
paint into a PaintCanvas originally and play that recorded result
back into an SkCanvas afterwards.

In the future, when PaintRecord is more introspectable by test code
and isn't just providing an SkPicture, then test code could just look
at the PaintRecord directly.

This code all works right now because cc::PaintCanvas is a typedef to
SkCanvas, but as soon as they become separate types then this code
will no longer work.

BUG=671433
==========

to

==========
Change mock canvases to paint into SkCanvas

To simplify interfaces, cc::PaintCanvas doesn't want to support onDrawX
style overrides while painting.  To avoid this, change test code that
paints into mock canvases and tries to detect what has been drawn to
paint into a PaintCanvas originally and play that recorded result
back into an SkCanvas afterwards.

In the future, when PaintRecord is more introspectable by test code
and isn't just providing an SkPicture, then test code could just look
at the PaintRecord directly.

This code all works right now because cc::PaintCanvas is a typedef to
SkCanvas, but as soon as they become separate types then this code
will no longer work.

BUG=671433

Review-Url: https://codereview.chromium.org/2715793002
Cr-Commit-Position: refs/heads/master@{#453060}
Committed:
https://chromium.googlesource.com/chromium/src/+/26abaa05f21dc00bd9f089e3aea0...
==========

[commit-bot: I haz the power, 2017-02-25 03:50:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/26abaa05f21dc00bd9f089e3aea0...