Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 2715783002: [DevTools] Fix 'node targets available' not appearing, but listed in Remote Devices drawer tab. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix 'node targets available' not appearing, but listed in Remote Devices drawer tab. Instead, those should be in ThreadsSidebarPane, but not in Remote Devices tab. BUG=689131 Review-Url: https://codereview.chromium.org/2715783002 Cr-Commit-Position: refs/heads/master@{#452969} Committed: https://chromium.googlesource.com/chromium/src/+/2b7d72f872ab3c2e590ac008c7dd8ac426982d48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dgozman
Could you please take a look?
3 years, 10 months ago (2017-02-24 19:51:41 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-24 19:52:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715783002/1
3 years, 10 months ago (2017-02-24 21:17:17 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 22:49:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b7d72f872ab3c2e590ac008c7dd...

Powered by Google App Engine
This is Rietveld 408576698