Add ShapeResult::RunInfo glyph iterators

Add ShapeResult::RunInfo glyph iterators

Introduce a couple of ShapeResult::RunInfo helper templates, to separate
the glyph iteration logic from the current glyphBuffer routines.  Refactor
existing clients to use these helpers.

The main objective is to externalize the glyph iteration logic (such that
it can be reused for direct ShapeResultBuffer->text blob construction in
the future), but the CL also includes a couple of tangential refactors:

  * simplify the character index range checks

  * de-templetize fillGlyphBufferForRun() and push the outer run loop into
    it (also renamed to fillGlyphBufferForResult and updated to return the
    total accumulated advance instead of advance delta)

Note on the last point: the TextDirection template param was only used for
index range checking;  with the refactors above, we only branch on
direction when the index is out-of-range - which is uncommon and doesn't
warrant template parametrization.


BUG=574136
R=drott@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2715773002
Cr-Commit-Position: refs/heads/master@{#453215}
Committed: https://chromium.googlesource.com/chromium/src/+/f90c9bae46bb1f944c1a6a9bff53e65e1cb29906

[f(malita), 2017-02-23 18:31:02]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 18:31:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-02-23 18:54:58]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 18:55:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-02-23 19:37:44]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 19:38:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-02-23 20:33:45]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 20:34:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 22:05:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:05:24]

Dry run: This issue passed the CQ dry run.

[f(malita), 2017-02-24 13:16:44]

Description was changed from

==========
Add ShapeResult::RunInfo glyph iterators

WIP

BUG=
==========

to

==========
Add ShapeResult::RunInfo glyph iterators

Introduce a couple of ShapeResult::RunInfo helper templates, to separate
the glyph iteration logic from the current glyphBuffer routines.  Refactor
existing clients to use these helpers.

The main objective is to externalize the glyph iteration logic such that
it can be reused for direct ShapeResultBuffer->text blob construction in
the future.

BUG=574136
R=drott@chromium.org,eae@chromium.org
==========

[f(malita), 2017-02-24 13:16:44]

fmalita@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[f(malita), 2017-02-24 13:23:37]

Description was changed from

==========
Add ShapeResult::RunInfo glyph iterators

Introduce a couple of ShapeResult::RunInfo helper templates, to separate
the glyph iteration logic from the current glyphBuffer routines.  Refactor
existing clients to use these helpers.

The main objective is to externalize the glyph iteration logic such that
it can be reused for direct ShapeResultBuffer->text blob construction in
the future.

BUG=574136
R=drott@chromium.org,eae@chromium.org
==========

to

==========
Add ShapeResult::RunInfo glyph iterators

Introduce a couple of ShapeResult::RunInfo helper templates, to separate
the glyph iteration logic from the current glyphBuffer routines.  Refactor
existing clients to use these helpers.

The main objective is to externalize the glyph iteration logic (such that
it can be reused for direct ShapeResultBuffer->text blob construction in
the future), but the CL also includes a couple of tangential refactors:

  * simplify the character index range checks

  * de-templetize fillGlyphBufferForRun() and push the outer run loop into
    it (and rename to fillGlyphBufferForResult)

Note on the last point: the TextDirection template param was only used for
index range checking;  with the refactors above, we only branch on
direction when the index is out-of-range - which is uncommon and doesn't
warrant template parametrization.


BUG=574136
R=drott@chromium.org,eae@chromium.org
==========

[f(malita), 2017-02-24 13:25:49]

Description was changed from

==========
Add ShapeResult::RunInfo glyph iterators

Introduce a couple of ShapeResult::RunInfo helper templates, to separate
the glyph iteration logic from the current glyphBuffer routines.  Refactor
existing clients to use these helpers.

The main objective is to externalize the glyph iteration logic (such that
it can be reused for direct ShapeResultBuffer->text blob construction in
the future), but the CL also includes a couple of tangential refactors:

  * simplify the character index range checks

  * de-templetize fillGlyphBufferForRun() and push the outer run loop into
    it (and rename to fillGlyphBufferForResult)

Note on the last point: the TextDirection template param was only used for
index range checking;  with the refactors above, we only branch on
direction when the index is out-of-range - which is uncommon and doesn't
warrant template parametrization.


BUG=574136
R=drott@chromium.org,eae@chromium.org
==========

to

==========
Add ShapeResult::RunInfo glyph iterators

Introduce a couple of ShapeResult::RunInfo helper templates, to separate
the glyph iteration logic from the current glyphBuffer routines.  Refactor
existing clients to use these helpers.

The main objective is to externalize the glyph iteration logic (such that
it can be reused for direct ShapeResultBuffer->text blob construction in
the future), but the CL also includes a couple of tangential refactors:

  * simplify the character index range checks

  * de-templetize fillGlyphBufferForRun() and push the outer run loop into
    it (also renamed to fillGlyphBufferForResult and updated to return the
    total accumulated advance instead of advance delta)

Note on the last point: the TextDirection template param was only used for
index range checking;  with the refactors above, we only branch on
direction when the index is out-of-range - which is uncommon and doesn't
warrant template parametrization.


BUG=574136
R=drott@chromium.org,eae@chromium.org
==========

[f(malita), 2017-02-24 13:33:45]

Cluster Telemetry 10k numbers look good - if anything, there's a small (0.5-2%)
improvement for the uncached configs:

https://storage.cloud.google.com/cluster-telemetry/tasks/chromium_perf_runs/f...

Fieldname                                 % Change  % Difference
pixels_rasterized                         0.015%    0.015%
viewport_picture_size                     0.005%    0.005%
record_time                              -0.036%   -0.036%
pixels_recorded                          -0.038%   -0.038%
rasterize_time                           -0.224%   -0.224%
record_time_partial_invalidation         -0.230%   -0.230%
record_time_caching_disabled             -0.543%   -0.544%
record_time_subsequence_caching_disabled -1.218%   -1.225%
record_time_painting_disabled            -1.275%   -1.284%
record_time_construction_disabled        -1.993%   -2.013%

[eae, 2017-02-25 01:20:52]

Nice cleanup! LGTM

[f(malita), 2017-02-27 13:58:26]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2017-02-27 13:58:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 15:21:29]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488203906641090,
"parent_rev": "1218f78b69ea2450c35ba3f4611304a10a17e2ae", "commit_rev":
"f90c9bae46bb1f944c1a6a9bff53e65e1cb29906"}

[commit-bot: I haz the power, 2017-02-27 15:22:09]

Description was changed from

==========
Add ShapeResult::RunInfo glyph iterators

Introduce a couple of ShapeResult::RunInfo helper templates, to separate
the glyph iteration logic from the current glyphBuffer routines.  Refactor
existing clients to use these helpers.

The main objective is to externalize the glyph iteration logic (such that
it can be reused for direct ShapeResultBuffer->text blob construction in
the future), but the CL also includes a couple of tangential refactors:

  * simplify the character index range checks

  * de-templetize fillGlyphBufferForRun() and push the outer run loop into
    it (also renamed to fillGlyphBufferForResult and updated to return the
    total accumulated advance instead of advance delta)

Note on the last point: the TextDirection template param was only used for
index range checking;  with the refactors above, we only branch on
direction when the index is out-of-range - which is uncommon and doesn't
warrant template parametrization.


BUG=574136
R=drott@chromium.org,eae@chromium.org
==========

to

==========
Add ShapeResult::RunInfo glyph iterators

Introduce a couple of ShapeResult::RunInfo helper templates, to separate
the glyph iteration logic from the current glyphBuffer routines.  Refactor
existing clients to use these helpers.

The main objective is to externalize the glyph iteration logic (such that
it can be reused for direct ShapeResultBuffer->text blob construction in
the future), but the CL also includes a couple of tangential refactors:

  * simplify the character index range checks

  * de-templetize fillGlyphBufferForRun() and push the outer run loop into
    it (also renamed to fillGlyphBufferForResult and updated to return the
    total accumulated advance instead of advance delta)

Note on the last point: the TextDirection template param was only used for
index range checking;  with the refactors above, we only branch on
direction when the index is out-of-range - which is uncommon and doesn't
warrant template parametrization.


BUG=574136
R=drott@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2715773002
Cr-Commit-Position: refs/heads/master@{#453215}
Committed:
https://chromium.googlesource.com/chromium/src/+/f90c9bae46bb1f944c1a6a9bff53...
==========

[commit-bot: I haz the power, 2017-02-27 15:22:11]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f90c9bae46bb1f944c1a6a9bff53...