Adding QUIC request headers to the net log observer

Adding QUIC request headers to the net log observer

The performance logs used in integration tests
(https://codereview.chromium.org/2705413004/) do not contain the
QUIC request headers. Since QUIC and H2 are structured similarly,
this is a minor change to support outputting QUIC request headers.

BUG=696731
Review-Url: https://codereview.chromium.org/2715743007
Cr-Commit-Position: refs/heads/master@{#453429}
Committed: https://chromium.googlesource.com/chromium/src/+/687ef074d2b0996276993f55547873dd8e9e4246

[RyanSturm, 2017-02-24 22:12:45]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 22:13:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-02-24 22:20:30]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[RyanSturm, 2017-02-24 22:21:25]

ryansturm@chromium.org changed reviewers:
+ csharrison@chromium.org

[RyanSturm, 2017-02-24 22:21:26]

csharrison: PTAL, thanks

[commit-bot: I haz the power, 2017-02-24 22:21:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-02-24 22:25:18]

Would you mind adding a test for this? Also, add a BUG= or remove it entirely.

[commit-bot: I haz the power, 2017-02-24 23:44:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 23:44:53]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-02-27 21:39:06]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 21:39:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-02-27 21:41:16]

Description was changed from

==========
Adding QUIC request headers to the net log observer

The performance logs used in integration tests
(https://codereview.chromium.org/2705413004/) do not contain the
QUIC request headers. Since QUIC and H2 are structured similarly,
this is a minor change to support outputting QUIC request headers.

BUG=
==========

to

==========
Adding QUIC request headers to the net log observer

The performance logs used in integration tests
(https://codereview.chromium.org/2705413004/) do not contain the
QUIC request headers. Since QUIC and H2 are structured similarly,
this is a minor change to support outputting QUIC request headers.

BUG=696731
==========

[RyanSturm, 2017-02-27 21:42:07]

Added unit tests for this class

csharrison: PTAL, thanks

[Charlie Harrison, 2017-02-27 21:54:44]

LGTM with some nits.

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
File content/browser/loader/netlog_observer_unittest.cc (right):

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
nit: 2017

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:36: namespace {
nit:
namespace {

<code>

}  // namespace

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:49: class NetLogObserverTest
: public testing::Test {
A brief comment here or above the actual tests would be great.

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:60: request_ =
context_.CreateRequest(GURL("test:test"), net::DEFAULT_PRIORITY,
Nit: let's hoist this URL up to a constant, make it maybe
"https://example.test", and reference it in BeginEvent down below.

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:102: void
VerifyHeaderValue(const std::string& header, const std::string& value) {
nit: expected_value?

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:107: EXPECT_EQ(header,
response->head.devtools_info->request_headers[0].first);
Maybe iterate through the headers so we can support adding multiple headers. It
seems fragile to always pull the first one.

[Charlie Harrison, 2017-02-27 22:04:07]

BTW I really appreciate that you wrote a test suite, especially considering this
CL was a one-liner! I thought this class already had one when I asked you for a
test.

[RyanSturm, 2017-02-27 22:12:25]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 22:13:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-02-27 22:13:09]

Thanks for the careful eye on the unit tests.

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
File content/browser/loader/netlog_observer_unittest.cc (right):

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2017/02/27 21:54:44, Charlie Harrison wrote:
> nit: 2017

Done.

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:36: namespace {
On 2017/02/27 21:54:43, Charlie Harrison wrote:
> nit:
> namespace {
> 
> <code>
> 
> }  // namespace

Done.

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:49: class NetLogObserverTest
: public testing::Test {
On 2017/02/27 21:54:43, Charlie Harrison wrote:
> A brief comment here or above the actual tests would be great.

Done.

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:60: request_ =
context_.CreateRequest(GURL("test:test"), net::DEFAULT_PRIORITY,
On 2017/02/27 21:54:43, Charlie Harrison wrote:
> Nit: let's hoist this URL up to a constant, make it maybe
> "https://example.test", and reference it in BeginEvent down below.

Done.

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:102: void
VerifyHeaderValue(const std::string& header, const std::string& value) {
On 2017/02/27 21:54:44, Charlie Harrison wrote:
> nit: expected_value?

Done.

https://codereview.chromium.org/2715743007/diff/40001/content/browser/loader/...
content/browser/loader/netlog_observer_unittest.cc:107: EXPECT_EQ(header,
response->head.devtools_info->request_headers[0].first);
On 2017/02/27 21:54:44, Charlie Harrison wrote:
> Maybe iterate through the headers so we can support adding multiple headers.
It
> seems fragile to always pull the first one.

Done.

[commit-bot: I haz the power, 2017-02-27 23:26:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 23:26:44]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-02-28 00:54:47]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2017-02-28 00:54:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2715743007/#ps60001
(title: "csharrison nits")

[commit-bot: I haz the power, 2017-02-28 00:55:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 01:04:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488243287709270,
"parent_rev": "f2e4ff7579e19d3f48d3aca2513470e5afdff01f", "commit_rev":
"687ef074d2b0996276993f55547873dd8e9e4246"}

[commit-bot: I haz the power, 2017-02-28 01:06:13]

Description was changed from

==========
Adding QUIC request headers to the net log observer

The performance logs used in integration tests
(https://codereview.chromium.org/2705413004/) do not contain the
QUIC request headers. Since QUIC and H2 are structured similarly,
this is a minor change to support outputting QUIC request headers.

BUG=696731
==========

to

==========
Adding QUIC request headers to the net log observer

The performance logs used in integration tests
(https://codereview.chromium.org/2705413004/) do not contain the
QUIC request headers. Since QUIC and H2 are structured similarly,
this is a minor change to support outputting QUIC request headers.

BUG=696731

Review-Url: https://codereview.chromium.org/2715743007
Cr-Commit-Position: refs/heads/master@{#453429}
Committed:
https://chromium.googlesource.com/chromium/src/+/687ef074d2b0996276993f555478...
==========

[commit-bot: I haz the power, 2017-02-28 01:06:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/687ef074d2b0996276993f555478...