Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2715733003: Revert of Switch WindowedNotificationObserver to use base::RunLoop. (Closed)

Created:
3 years, 10 months ago by Marc Treib
Modified:
3 years, 10 months ago
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, vabr+watchlistlogin_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch WindowedNotificationObserver to use base::RunLoop. (patchset #4 id:60001 of https://codereview.chromium.org/2701473007/ ) Reason for revert: Suspected of causing flakiness in PrintPreviewDialogControllerBrowserTest.ReloadInitiatorTab More details in crbug.com/695835 Original issue's description: > Switch WindowedNotificationObserver to use base::RunLoop. > > Now it will quit the message loop immediately after receiving the > notification. Also it does not allow nested tasks anymore. > > BUG=668707 > > Review-Url: https://codereview.chromium.org/2701473007 > Cr-Commit-Position: refs/heads/master@{#452739} > Committed: https://chromium.googlesource.com/chromium/src/+/474e1f148ab83dde92b93a93e53cf83d77b9be13 TBR=jochen@chromium.org,rdevlin.cronin@chromium.org,ahest@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668707 Review-Url: https://codereview.chromium.org/2715733003 Cr-Commit-Position: refs/heads/master@{#452800} Committed: https://chromium.googlesource.com/chromium/src/+/0fc562c98c420de40daa775a1aacb52a4760a9b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -176 lines) Patch
M chrome/browser/chromeos/login/login_manager_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/ui/login/login_handler_browsertest.cc View 2 chunks +89 lines, -88 lines 0 comments Download
M chrome/browser/ui/login/login_handler_test_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/login/login_handler_test_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/find_bar_views_interactive_uitest.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 2 chunks +21 lines, -48 lines 0 comments Download
M content/public/test/test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/test/extension_test_notification_observer.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Marc Treib
Created Revert of Switch WindowedNotificationObserver to use base::RunLoop.
3 years, 10 months ago (2017-02-24 12:48:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715733003/1
3 years, 10 months ago (2017-02-24 12:48:31 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 12:49:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0fc562c98c420de40daa775a1aac...

Powered by Google App Engine
This is Rietveld 408576698