Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2715673002: Update QR Code scanner caption string and padding. (Closed)

Created:
3 years, 10 months ago by jif
Modified:
3 years, 9 months ago
Reviewers:
jasonkliu, lpromero
CC:
chromium-reviews, marq+watch_chromium.org, sdefresne+watch_chromium.org, srahim+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update QR Code scanner caption string and padding. BUG=694739 Review-Url: https://codereview.chromium.org/2715673002 Cr-Commit-Position: refs/heads/master@{#454246} Committed: https://chromium.googlesource.com/chromium/src/+/ae62f34fd5f4883f1a7dc5c8cf0e895b1d6624ef

Patch Set 1 #

Patch Set 2 : Fix padding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
jif
ptal I won't land this until the string change is approved.
3 years, 10 months ago (2017-02-23 09:43:01 UTC) #3
jasonkliu
lgtm
3 years, 10 months ago (2017-02-23 14:36:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715673002/20001
3 years, 9 months ago (2017-03-01 18:24:38 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-01 18:24:41 UTC) #10
jif
ptal
3 years, 9 months ago (2017-03-01 18:25:35 UTC) #12
lpromero
lgtm
3 years, 9 months ago (2017-03-02 12:55:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715673002/20001
3 years, 9 months ago (2017-03-02 12:55:59 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 13:37:34 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae62f34fd5f4883f1a7dc5c8cf0e...

Powered by Google App Engine
This is Rietveld 408576698