Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2715663005: [DevTools] Add header for OOPIF's elements trees. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add header for OOPIF's elements trees. They are now separated by the "Frame <link>" headers. We will probably experiment with tabs later. BUG=678442 Review-Url: https://codereview.chromium.org/2715663005 Cr-Commit-Position: refs/heads/master@{#453407} Committed: https://chromium.googlesource.com/chromium/src/+/b3f79d4d77ed2b095cc5959f975be917eccc81c4

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 5 chunks +39 lines, -1 line 3 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dgozman
Take a look please.
3 years, 10 months ago (2017-02-23 22:21:35 UTC) #4
pfeldman
https://codereview.chromium.org/2715663005/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/2715663005/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js#newcode83 third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:83: this._treeOutlineHeaders = new Map(); Why you no use symbols? ...
3 years, 10 months ago (2017-02-23 23:49:41 UTC) #7
pfeldman
lgtm https://codereview.chromium.org/2715663005/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/2715663005/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js#newcode267 third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:267: header.createChild('div', 'elements-tree-header-frame').textContent = Common.UIString('Frame'); You can use .formatLocalized.
3 years, 10 months ago (2017-02-24 19:39:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715663005/1
3 years, 9 months ago (2017-02-27 22:55:00 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 00:17:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b3f79d4d77ed2b095cc5959f975b...

Powered by Google App Engine
This is Rietveld 408576698