Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2715573002: Fix up pylint warnings in run_webkit_tests_unittest.py. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix up pylint warnings in run_webkit_tests_unittest.py. In this CL: - remove unused arg in helper function - rename methods to conform to naming convention - add pylint disable to not warn about testing protected methods BUG=643937 Review-Url: https://codereview.chromium.org/2715573002 Cr-Commit-Position: refs/heads/master@{#452317} Committed: https://chromium.googlesource.com/chromium/src/+/aaa73ea0f5ac4aadf0f30e12a3e86fa3388ec1be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 19 chunks +37 lines, -37 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
qyearsley
This is another minor clean-up CL... could you check and let me know if anything ...
3 years, 10 months ago (2017-02-22 23:15:24 UTC) #3
tkent
lgtm
3 years, 10 months ago (2017-02-22 23:23:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715573002/1
3 years, 10 months ago (2017-02-22 23:30:31 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 00:54:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aaa73ea0f5ac4aadf0f30e12a3e8...

Powered by Google App Engine
This is Rietveld 408576698