Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2715543004: Only show UserManager and sign in dialog after profile deleting if fallback profile is locked, when… (Closed)

Created:
3 years, 10 months ago by zmin
Modified:
3 years, 9 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only show UserManager and sign in dialog after profile deleting if fallback profile is locked, when force-sign-in policy is enabled. BUG=642059 Review-Url: https://codereview.chromium.org/2715543004 Cr-Commit-Position: refs/heads/master@{#453369} Committed: https://chromium.googlesource.com/chromium/src/+/d00656ece1ae3378d3206cb5aca23d4566158b6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/ui/webui/profile_helper.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
zmin
Hi tommycli, Can you review this CL please? Owen
3 years, 10 months ago (2017-02-23 23:47:51 UTC) #4
tommycli
lgtm if the following understanding is correct: We only want to show the user manager ...
3 years, 9 months ago (2017-02-27 21:38:34 UTC) #7
zmin
On 2017/02/27 21:38:34, tommycli wrote: > lgtm if the following understanding is correct: > > ...
3 years, 9 months ago (2017-02-27 21:43:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715543004/1
3 years, 9 months ago (2017-02-27 21:43:44 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 22:50:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d00656ece1ae3378d3206cb5aca2...

Powered by Google App Engine
This is Rietveld 408576698