Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2715543002: Merge Arrays in plist_util.py (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge Arrays in plist_util.py The plist templates can have different values for the same key. If the value is a list (plist array), merge should be the concatenation. Don't compute union as as list can contain dicts. BUG=692552 Review-Url: https://codereview.chromium.org/2715543002 Cr-Commit-Position: refs/heads/master@{#452083} Committed: https://chromium.googlesource.com/chromium/src/+/0cf3dac55d77555df465f3809e8f8636efef303d

Patch Set 1 #

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/config/mac/plist_util.py View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Olivier
3 years, 10 months ago (2017-02-22 15:06:47 UTC) #2
sdefresne
lgtm
3 years, 10 months ago (2017-02-22 16:05:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715543002/20001
3 years, 10 months ago (2017-02-22 16:06:33 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 16:43:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0cf3dac55d77555df465f3809e8f...

Powered by Google App Engine
This is Rietveld 408576698