Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2715533004: Mojo C++ Bindings: Introduce build-time option to disable typemapping (Closed)

Created:
3 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 10 months ago
Reviewers:
Sam McNally
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ Bindings: Introduce build-time option to disable typemapping Introduces the GN arg |enable_mojom_typemapping| which defaults to |true|. Setting this to |false| is strictly for use in non-Chromium build configurations, e.g. external projects which wish to use Mojo bindings and which may not wish to mirror the entire Chromium source tree. When set to |false|, it avoids a build-time dependency on the global Chromium and Blink typemap configurations. BUG=695242 R=sammc@chromium.org Review-Url: https://codereview.chromium.org/2715533004 Cr-Commit-Position: refs/heads/master@{#452359} Committed: https://chromium.googlesource.com/chromium/src/+/f303a2c28ad93a3aeb09469782454b30ac6c9915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -22 lines) Patch
M mojo/public/tools/bindings/mojom.gni View 2 chunks +48 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Ken Rockot(use gerrit already)
PTAL
3 years, 10 months ago (2017-02-23 01:19:51 UTC) #5
Sam McNally
I expect in the longer term, we'll want to allow specifying custom bindings configuration files ...
3 years, 10 months ago (2017-02-23 02:13:56 UTC) #6
Ken Rockot(use gerrit already)
On 2017/02/23 at 02:13:56, sammc wrote: > I expect in the longer term, we'll want ...
3 years, 10 months ago (2017-02-23 02:14:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715533004/1
3 years, 10 months ago (2017-02-23 02:15:45 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 02:52:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f303a2c28ad93a3aeb0946978245...

Powered by Google App Engine
This is Rietveld 408576698