Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2715513007: [compiler] Tune lowering of CheckedUint32ToInt32. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Tune lowering of CheckedUint32ToInt32. Instead of creating a signed comparison with INT_MAX, create an unsigned comparison with 0. This saves a few bytes in the generated code. R=jarin@chromium.org BUG= Review-Url: https://codereview.chromium.org/2715513007 Cr-Commit-Position: refs/heads/master@{#43606} Committed: https://chromium.googlesource.com/v8/v8/+/c56c2013adaa50028fb20f7579addfe014826ae2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
neis
3 years, 10 months ago (2017-02-23 10:28:21 UTC) #1
Jarin
lgtm, thanks!
3 years, 9 months ago (2017-03-06 10:41:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715513007/1
3 years, 9 months ago (2017-03-06 10:42:04 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 11:08:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c56c2013adaa50028fb20f7579addfe0148...

Powered by Google App Engine
This is Rietveld 408576698