Split non-//content parts from ContentAutofillDriverFactory

Split non-//content parts from ContentAutofillDriverFactory

This CL extracts the logic for managing AutofillDriver instances from
ContentAutofillDriverFactory and puts it in a separate AutofillDriverFactory
class. The goal is to achieve better testability. More details are in the
design doc
https://docs.google.com/a/chromium.org/document/d/1CZRzRv5p1SnClgOYydZ7epVpEqYxJdgRSCEpRXml-xU/edit?usp=sharing.

BUG=669045
Review-Url: https://codereview.chromium.org/2715483002
Cr-Commit-Position: refs/heads/master@{#452258}
Committed: https://chromium.googlesource.com/chromium/src/+/f68e6ab0d88250d9547590aadc0d885399979158

[vabr (Chromium), 2017-02-22 12:26:49]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 12:27:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 13:42:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 13:42:36]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-02-22 15:28:31]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 15:28:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 16:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 16:51:06]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-02-22 16:53:38]

vabr@chromium.org changed reviewers:
+ sebsg@chromium.org

[vabr (Chromium), 2017-02-22 16:53:39]

Hi Sebastien,

Could you please review this CL?

Thank you,
Vaclav

[sebsg, 2017-02-22 21:07:47]

LGTM % small nit.

Major League code here, very nice! Thanks for doing this.

https://codereview.chromium.org/2715483002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_driver_factory_unittest.cc
(right):

https://codereview.chromium.org/2715483002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_driver_factory_unittest.cc:139:
EXPECT_EQ(1, drivers_created_);
Can you add a check for instances here too?

[vabr (Chromium), 2017-02-22 21:38:33]

Thanks for your kind and very fast review, Sebastien!

Cheers,
Vaclav

https://codereview.chromium.org/2715483002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_driver_factory_unittest.cc
(right):

https://codereview.chromium.org/2715483002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_driver_factory_unittest.cc:139:
EXPECT_EQ(1, drivers_created_);
On 2017/02/22 21:07:47, sebsg wrote:
> Can you add a check for instances here too?

Done.

[vabr (Chromium), 2017-02-22 21:38:39]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-02-22 21:38:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2715483002/#ps40001
(title: "Add instances check")

[commit-bot: I haz the power, 2017-02-22 21:39:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 23:08:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487799519790930,
"parent_rev": "4619cd290ca38163c88065f7c273df19d2a577fa", "commit_rev":
"f68e6ab0d88250d9547590aadc0d885399979158"}

[commit-bot: I haz the power, 2017-02-22 23:10:05]

Description was changed from

==========
Split non-//content parts from ContentAutofillDriverFactory

This CL extracts the logic for managing AutofillDriver instances from
ContentAutofillDriverFactory and puts it in a separate AutofillDriverFactory
class. The goal is to achieve better testability. More details are in the
design doc
https://docs.google.com/a/chromium.org/document/d/1CZRzRv5p1SnClgOYydZ7epVpEq....

BUG=669045
==========

to

==========
Split non-//content parts from ContentAutofillDriverFactory

This CL extracts the logic for managing AutofillDriver instances from
ContentAutofillDriverFactory and puts it in a separate AutofillDriverFactory
class. The goal is to achieve better testability. More details are in the
design doc
https://docs.google.com/a/chromium.org/document/d/1CZRzRv5p1SnClgOYydZ7epVpEq....

BUG=669045

Review-Url: https://codereview.chromium.org/2715483002
Cr-Commit-Position: refs/heads/master@{#452258}
Committed:
https://chromium.googlesource.com/chromium/src/+/f68e6ab0d88250d9547590aadc0d...
==========

[commit-bot: I haz the power, 2017-02-22 23:10:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f68e6ab0d88250d9547590aadc0d...