Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2715473004: Avoid unnecessary HashTable resizing during copy construction. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
haraken, esprehn
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid unnecessary HashTable resizing during copy construction. We do know the final table size, so reserve its size before starting to copy over. Thereby avoiding intermediate table allocations. R=esprehn BUG= Review-Url: https://codereview.chromium.org/2715473004 Cr-Commit-Position: refs/heads/master@{#452060} Committed: https://chromium.googlesource.com/chromium/src/+/c1f114d257fb0edcf6cc54ab871cd48638d8601c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/wtf/HashTable.h View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look. Noticed some allocation churn due to this for resource responses & ...
3 years, 10 months ago (2017-02-22 14:33:14 UTC) #4
esprehn
lgtm
3 years, 10 months ago (2017-02-22 14:44:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715473004/1
3 years, 10 months ago (2017-02-22 15:23:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c1f114d257fb0edcf6cc54ab871cd48638d8601c
3 years, 10 months ago (2017-02-22 15:28:21 UTC) #13
haraken
3 years, 10 months ago (2017-02-22 23:27:30 UTC) #14
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698