Remove non-MD code from LabelTrayView

Remove non-MD code from LabelTrayView

Remove the non-MD code paths from LabelTrayView, a class
used in the Ash system menu. Also remove the now-unused
PNG image assets for enterprise, session length limit,
child user, and supervised user.

BUG=686217
Review-Url: https://codereview.chromium.org/2715463004
Cr-Commit-Position: refs/heads/master@{#460764}
Committed: https://chromium.googlesource.com/chromium/src/+/69e9d1d70b20868d1f0ae07133eb3ca23928f213

[tdanderson, 2017-02-22 21:32:07]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 21:34:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-02-22 21:35:31]

tdanderson@chromium.org changed reviewers:
+ estade@chromium.org

[tdanderson, 2017-02-22 21:35:32]

Evan, can you please take a look?

[Evan Stade, 2017-02-22 21:43:46]

lgtm

cool. Thanks for updating to the vector icon structs as well.

re: CHECK/DCHECK, I think we prefer DCHECK unless we're actively hunting down a
crash that we can't repro locally or if we're worrying about threat vectors or
something.

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/enterprise/tray_enterprise.cc (right):

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/enterprise/tray_enterprise.cc:35: CHECK(!tray_view_);
nit: DCHECK

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/enterprise/tray_enterprise.cc:45: void
TrayEnterprise::DestroyDefaultView() {
aside: it seems like this should be called DefaultViewDestroyed since you don't
actually own the default view. Alternately we could do
tray_view_->set_owned_by_client() and actually destroy it here so that this
function name makes sense, but I think changing the function name to match
behavior is better than vice versa.

I assume this pattern is the same everywhere we have a tray item overriding
Destroy*View().

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/supervised/tray_supervised_user.cc (right):

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/supervised/tray_supervised_user.cc:57:
CHECK(!tray_view_);
nit: DCHECK

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/supervised/tray_supervised_user.cc:127:
CHECK(delegate->IsUserSupervised());
nit: DCHECK

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/tray/labe...
File ash/common/system/tray/label_tray_view.h (right):

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/tray/labe...
ash/common/system/tray/label_tray_view.h:20: // automatically hides when the
message text is empty. Multi-line
seems like this comment is wrapped early

[commit-bot: I haz the power, 2017-02-22 22:27:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 22:27:30]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-03-22 21:38:05]

ping?

[tdanderson, 2017-03-28 22:33:02]

On 2017/03/22 21:38:05, Evan Stade wrote:
> ping?

Sorry, will be returning to this + other cleanup tasks this week.

[tdanderson, 2017-03-30 14:21:05]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 14:21:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-03-30 14:51:39]

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/enterprise/tray_enterprise.cc (right):

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/enterprise/tray_enterprise.cc:35: CHECK(!tray_view_);
On 2017/02/22 21:43:46, Evan Stade wrote:
> nit: DCHECK

Done.

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/enterprise/tray_enterprise.cc:45: void
TrayEnterprise::DestroyDefaultView() {
On 2017/02/22 21:43:46, Evan Stade wrote:
> aside: it seems like this should be called DefaultViewDestroyed since you
don't
> actually own the default view. Alternately we could do
> tray_view_->set_owned_by_client() and actually destroy it here so that this
> function name makes sense, but I think changing the function name to match
> behavior is better than vice versa.

Yes, agreed. Filed https://bugs.chromium.org/p/chromium/issues/detail?id=706821
to track that.

> 
> I assume this pattern is the same everywhere we have a tray item overriding
> Destroy*View().

I believe it is, yes.

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/supervised/tray_supervised_user.cc (right):

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/supervised/tray_supervised_user.cc:57:
CHECK(!tray_view_);
On 2017/02/22 21:43:46, Evan Stade wrote:
> nit: DCHECK

Done.

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/supervised/tray_supervised_user.cc:127:
CHECK(delegate->IsUserSupervised());
On 2017/02/22 21:43:46, Evan Stade wrote:
> nit: DCHECK

Done.

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/tray/labe...
File ash/common/system/tray/label_tray_view.h (right):

https://codereview.chromium.org/2715463004/diff/1/ash/common/system/tray/labe...
ash/common/system/tray/label_tray_view.h:20: // automatically hides when the
message text is empty. Multi-line
On 2017/02/22 21:43:46, Evan Stade wrote:
> seems like this comment is wrapped early

Done.

[tdanderson, 2017-03-30 14:51:47]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2017-03-30 14:51:48]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2715463004/#ps40001
(title: "estade comments")

[commit-bot: I haz the power, 2017-03-30 14:52:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 15:25:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490885507732690,
"parent_rev": "b6082fccb8e9fc2f21871508bdcf79ca567326ad", "commit_rev":
"69e9d1d70b20868d1f0ae07133eb3ca23928f213"}

[commit-bot: I haz the power, 2017-03-30 15:27:14]

Description was changed from

==========
Remove non-MD code from LabelTrayView

Remove the non-MD code paths from LabelTrayView, a class
used in the Ash system menu. Also remove the now-unused
PNG image assets for enterprise, session length limit,
child user, and supervised user.

BUG=686217
==========

to

==========
Remove non-MD code from LabelTrayView

Remove the non-MD code paths from LabelTrayView, a class
used in the Ash system menu. Also remove the now-unused
PNG image assets for enterprise, session length limit,
child user, and supervised user.

BUG=686217

Review-Url: https://codereview.chromium.org/2715463004
Cr-Commit-Position: refs/heads/master@{#460764}
Committed:
https://chromium.googlesource.com/chromium/src/+/69e9d1d70b20868d1f0ae07133eb...
==========

[commit-bot: I haz the power, 2017-03-30 15:27:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/69e9d1d70b20868d1f0ae07133eb...