Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2715463002: Remove AssociatedDomains.entitlements from upstream tree. (Closed)

Created:
3 years, 10 months ago by sdefresne
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AssociatedDomains.entitlements from upstream tree. This entitlement is there to associate the goo.gl domain with Chrome. This requires having the correct capabilities on the used certificates (i.e. requires using Google certificates). BUG=694604 Review-Url: https://codereview.chromium.org/2715463002 Cr-Commit-Position: refs/heads/master@{#452062} Committed: https://chromium.googlesource.com/chromium/src/+/bdb93c7b5c6c6568e5ce7c8825d3d28b74a23ddb

Patch Set 1 #

Patch Set 2 : Rebase on origin/master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M ios/chrome/app/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
D ios/chrome/app/resources/AssociatedDomains.entitlements View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sdefresne
Please take a look.
3 years, 10 months ago (2017-02-22 10:51:02 UTC) #3
noyau (Ping after 24h)
lgtm
3 years, 10 months ago (2017-02-22 12:10:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715463002/20001
3 years, 10 months ago (2017-02-22 14:29:26 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 15:30:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bdb93c7b5c6c6568e5ce7c8825d3...

Powered by Google App Engine
This is Rietveld 408576698