🏡 Add a ChromeHomeNewTabPage

chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java
index 0bf53e9ea7037adc39357ea5924de151f52e4292..ac82c31c2b6af47419ac81f1b49f3baf71e1aaf7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java
@@ -24,7 +24,7 @@ import android.widget.FrameLayout;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ntp.LogoBridge.Logo;
-import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
+import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;
 import org.chromium.chrome.browser.widget.LoadingView;
 
 import java.lang.ref.WeakReference;
@@ -67,7 +67,7 @@ public class LogoView extends FrameLayout implements OnClickListener {
      */
     private float mTransitionAmount;
 
-    private NewTabPageManager mManager;
+    private LogoManager mManager;
 
     private final Property<LogoView, Float> mTransitionProperty =
             new Property<LogoView, Float>(Float.class, "") {
@@ -88,6 +88,23 @@ public class LogoView extends FrameLayout implements OnClickListener {
     };
 
     /**
+     * Manages the {@link LogoView} shown on an NTP.
+     */
+    public interface LogoManager {

[Michael van Ouwerkerk, 2017/02/28 13:36:15]

Can we rename this to Delegate and refer to LogoView.Delegate everywhere? I
think "delegate" expresses what this does a bit more accurately than "manager"
and we avoid the duplication in LogoView.LogoManager. It's what we've been
moving to when breaking pieces out of the NewTabPageManager:
https://cs.chromium.org/search/?q=f:ntp%7Csuggestions+interface.*Delegate+lan...

[Theresa, 2017/02/28 17:02:23]

Done.

+        /**
+         * Called when the user clicks on the logo.
+         * @param isAnimatedLogoShowing Whether the animated GIF logo is playing.
+         */
+        void onLogoClicked(boolean isAnimatedLogoShowing);
+
+        /**
+         * Gets the default search provider's logo and calls logoObserver with the result.
+         * @param logoObserver The callback to notify when the logo is available.
+         */
+        void getSearchProviderLogo(LogoObserver logoObserver);
+    }
+
+    /**
      * Constructor used to inflate a LogoView from XML.
      */
     public LogoView(Context context, AttributeSet attrs) {
@@ -115,9 +132,9 @@ public class LogoView extends FrameLayout implements OnClickListener {
     }
 
     /**
-     * Sets the NewTabPageManager to notify when the logo is pressed.
+     * Sets the LogoManager to notify when the logo is pressed.
      */
-    public void setMananger(NewTabPageManager manager) {
+    public void setMananger(LogoManager manager) {
         mManager = manager;
     }