🏡 Add a ChromeHomeNewTabPage

chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp;
 
 import android.animation.Animator;
 import android.animation.ObjectAnimator;
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.Bitmap.Config;
 import android.graphics.BitmapFactory;
 import android.graphics.Canvas;
 import android.graphics.Matrix;
 import android.graphics.Paint;
 import android.graphics.drawable.Drawable;
 import android.text.TextUtils;
 import android.util.AttributeSet;
 import android.util.Property;
 import android.view.Gravity;
 import android.view.View;
 import android.view.View.OnClickListener;
 import android.widget.FrameLayout;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ntp.LogoBridge.Logo;
-import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
+import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;
 import org.chromium.chrome.browser.widget.LoadingView;
 
 import java.lang.ref.WeakReference;
 
 import jp.tomorrowkey.android.gifplayer.BaseGifDrawable;
 import jp.tomorrowkey.android.gifplayer.BaseGifImage;
 
 /**
  * This view shows the default search provider's logo and fades in a new logo if one becomes
  * available. It also maintains a {@link BaseGifDrawable} that will be played when the user clicks
@@ skipping 22 matching lines @@
 
     private LoadingView mLoadingView;
 
     /**
      * A measure from 0 to 1 of how much the new logo has faded in. 0 shows the old logo, 1 shows
      * the new logo, and intermediate values show the new logo cross-fading in over the old logo.
      * Set to 0 when not transitioning.
      */
     private float mTransitionAmount;
 
-    private NewTabPageManager mManager;
+    private LogoManager mManager;
 
     private final Property<LogoView, Float> mTransitionProperty =
             new Property<LogoView, Float>(Float.class, "") {
         @Override
         public Float get(LogoView logoView) {
             return logoView.mTransitionAmount;
         }
 
         @Override
         public void set(LogoView logoView, Float amount) {
             assert amount >= 0f;
             assert amount <= 1f;
             if (logoView.mTransitionAmount != amount) {
                 logoView.mTransitionAmount = amount;
                 invalidate();
             }
         }
     };
 
     /**
+     * Manages the {@link LogoView} shown on an NTP.
+     */
+    public interface LogoManager {

[Michael van Ouwerkerk, 2017/02/28 13:36:15]

Can we rename this to Delegate and refer to LogoView.Delegate everywhere? I
think "delegate" expresses what this does a bit more accurately than "manager"
and we avoid the duplication in LogoView.LogoManager. It's what we've been
moving to when breaking pieces out of the NewTabPageManager:
https://cs.chromium.org/search/?q=f:ntp%7Csuggestions+interface.*Delegate+lan...

[Theresa, 2017/02/28 17:02:23]

Done.

+        /**
+         * Called when the user clicks on the logo.
+         * @param isAnimatedLogoShowing Whether the animated GIF logo is playing.
+         */
+        void onLogoClicked(boolean isAnimatedLogoShowing);
+
+        /**
+         * Gets the default search provider's logo and calls logoObserver with the result.
+         * @param logoObserver The callback to notify when the logo is available.
+         */
+        void getSearchProviderLogo(LogoObserver logoObserver);
+    }
+
+    /**
      * Constructor used to inflate a LogoView from XML.
      */
     public LogoView(Context context, AttributeSet attrs) {
         super(context, attrs);
 
         mLogo = getDefaultLogo();
         mLogoMatrix = new Matrix();
         mLogoIsDefault = true;
 
         mPaint = new Paint();
         mPaint.setFilterBitmap(true);
 
         // Mark this view as non-clickable so that accessibility will ignore it. When a non-default
         // logo is shown, this view will be marked clickable again.
         setOnClickListener(this);
         setClickable(false);
         setWillNotDraw(false);
 
         mLoadingView = new LoadingView(getContext());
         LayoutParams lp = new LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT);
         lp.gravity = Gravity.CENTER;
         mLoadingView.setLayoutParams(lp);
         mLoadingView.setVisibility(View.GONE);
         addView(mLoadingView);
     }
 
     /**
-     * Sets the NewTabPageManager to notify when the logo is pressed.
+     * Sets the LogoManager to notify when the logo is pressed.
      */
-    public void setMananger(NewTabPageManager manager) {
+    public void setMananger(LogoManager manager) {
         mManager = manager;
     }
 
     /**
      * Jumps to the end of the logo cross-fading animation, if any.
      */
     public void endFadeAnimation() {
         if (mFadeAnimation != null) {
             mFadeAnimation.end();
             mFadeAnimation = null;
@@ skipping 188 matching lines @@
         }
     }
 
     @Override
     public void onClick(View view) {
         if (view == this && mManager != null && !isTransitioning()) {
             mManager.onLogoClicked(isAnimatedLogoShowing());
         }
     }
 }