components/offline_pages/core/background/offliner_stub.h - Issue 2715433006: [Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/background/offliner_stub.h

Issue 2715433006: [Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions (Closed)

Patch Set: forgot to init Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/core/background/offliner_stub.h

diff --git a/components/offline_pages/core/background/offliner_stub.h b/components/offline_pages/core/background/offliner_stub.h

index 821f5ea9ed5f10acc164a13ab4a49c170cfce4a7..16abb8f7b62e8a6491f650f3ec11ae9974864122 100644

--- a/components/offline_pages/core/background/offliner_stub.h

+++ b/components/offline_pages/core/background/offliner_stub.h

@@ -19,7 +19,7 @@ class OfflinerStub : public Offliner {

bool LoadAndSave(const SavePageRequest& request,

const CompletionCallback& callback) override;

- void Cancel() override;

+ void Cancel(const CancelCallback& callback) override;

void disable_loading() { disable_loading_ = true; }