components/offline_pages/core/background/offliner_stub.cc - Issue 2715433006: [Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/background/offliner_stub.cc

Issue 2715433006: [Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions (Closed)

Patch Set: forgot to init Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/core/background/offliner_stub.cc

diff --git a/components/offline_pages/core/background/offliner_stub.cc b/components/offline_pages/core/background/offliner_stub.cc

index 3b3c1f56164da0ca94ff8a3f7633e756edf5b49b..c007ae0a0aa54edb3e1e020de51101aa8ea367ee 100644

--- a/components/offline_pages/core/background/offliner_stub.cc

+++ b/components/offline_pages/core/background/offliner_stub.cc

@@ -34,8 +34,9 @@ bool OfflinerStub::LoadAndSave(const SavePageRequest& request,

return true;

}

-void OfflinerStub::Cancel() {

+void OfflinerStub::Cancel(const CancelCallback& callback) {

cancel_called_ = true;

+ callback.Run(0LL);

}

bool OfflinerStub::HandleTimeout(const SavePageRequest& request) {