Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2641)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2715433006: [Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions (Closed)
Patch Set: forgot to init Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.h
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.h b/chrome/browser/android/offline_pages/prerendering_offliner.h
index 9b1104cc57c095584df446246558d7c27dbe1107..935d3019f145d8a2c192c960d62bc5f9f8f43b7b 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.h
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.h
@@ -36,7 +36,7 @@ class PrerenderingOffliner : public Offliner {
// Offliner implementation.
bool LoadAndSave(const SavePageRequest& request,
const CompletionCallback& callback) override;
- void Cancel() override;
+ void Cancel(const CancelCallback& callback) override;
bool HandleTimeout(const SavePageRequest& request) override;
// Allows a loader to be injected for testing. This may only be done once
@@ -76,6 +76,8 @@ class PrerenderingOffliner : public Offliner {
// Listener function for changes to application background/foreground state.
void OnApplicationStateChange(
base::android::ApplicationState application_state);
+ void HandleApplicationStateChangeCancel(const SavePageRequest& request,
+ int64_t offline_id);
// Not owned.
content::BrowserContext* browser_context_;

Powered by Google App Engine
This is Rietveld 408576698