Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2715433006: [Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions (Closed)
Patch Set: forgot to init Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_
6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_ 6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/android/application_status_listener.h" 10 #include "base/android/application_status_listener.h"
(...skipping 18 matching lines...) Expand all
29 class PrerenderingOffliner : public Offliner { 29 class PrerenderingOffliner : public Offliner {
30 public: 30 public:
31 PrerenderingOffliner(content::BrowserContext* browser_context, 31 PrerenderingOffliner(content::BrowserContext* browser_context,
32 const OfflinerPolicy* policy, 32 const OfflinerPolicy* policy,
33 OfflinePageModel* offline_page_model); 33 OfflinePageModel* offline_page_model);
34 ~PrerenderingOffliner() override; 34 ~PrerenderingOffliner() override;
35 35
36 // Offliner implementation. 36 // Offliner implementation.
37 bool LoadAndSave(const SavePageRequest& request, 37 bool LoadAndSave(const SavePageRequest& request,
38 const CompletionCallback& callback) override; 38 const CompletionCallback& callback) override;
39 void Cancel() override; 39 void Cancel(const CancelCallback& callback) override;
40 bool HandleTimeout(const SavePageRequest& request) override; 40 bool HandleTimeout(const SavePageRequest& request) override;
41 41
42 // Allows a loader to be injected for testing. This may only be done once 42 // Allows a loader to be injected for testing. This may only be done once
43 // and must be called before any of the Offliner interface methods are called. 43 // and must be called before any of the Offliner interface methods are called.
44 void SetLoaderForTesting(std::unique_ptr<PrerenderingLoader> loader); 44 void SetLoaderForTesting(std::unique_ptr<PrerenderingLoader> loader);
45 45
46 void SetLowEndDeviceForTesting(bool is_low_end_device); 46 void SetLowEndDeviceForTesting(bool is_low_end_device);
47 47
48 void SetApplicationStateForTesting( 48 void SetApplicationStateForTesting(
49 base::android::ApplicationState application_state); 49 base::android::ApplicationState application_state);
(...skipping 19 matching lines...) Expand all
69 // Callback logic for OfflinePageModel::SavePage(). 69 // Callback logic for OfflinePageModel::SavePage().
70 void OnSavePageDone(const SavePageRequest& request, 70 void OnSavePageDone(const SavePageRequest& request,
71 SavePageResult save_result, 71 SavePageResult save_result,
72 int64_t offline_id); 72 int64_t offline_id);
73 73
74 PrerenderingLoader* GetOrCreateLoader(); 74 PrerenderingLoader* GetOrCreateLoader();
75 75
76 // Listener function for changes to application background/foreground state. 76 // Listener function for changes to application background/foreground state.
77 void OnApplicationStateChange( 77 void OnApplicationStateChange(
78 base::android::ApplicationState application_state); 78 base::android::ApplicationState application_state);
79 void HandleApplicationStateChangeCancel(const SavePageRequest& request,
80 int64_t offline_id);
79 81
80 // Not owned. 82 // Not owned.
81 content::BrowserContext* browser_context_; 83 content::BrowserContext* browser_context_;
82 // Not owned. 84 // Not owned.
83 const OfflinerPolicy* policy_; 85 const OfflinerPolicy* policy_;
84 // Not owned. 86 // Not owned.
85 OfflinePageModel* offline_page_model_; 87 OfflinePageModel* offline_page_model_;
86 // Lazily created. 88 // Lazily created.
87 std::unique_ptr<PrerenderingLoader> loader_; 89 std::unique_ptr<PrerenderingLoader> loader_;
88 // Tracks pending request, if any. Owned copy. 90 // Tracks pending request, if any. Owned copy.
89 // May be used to ensure a callback applies to the pending request (e.g., in 91 // May be used to ensure a callback applies to the pending request (e.g., in
90 // case we receive a save page callback for an old, canceled request). 92 // case we receive a save page callback for an old, canceled request).
91 std::unique_ptr<SavePageRequest> pending_request_; 93 std::unique_ptr<SavePageRequest> pending_request_;
92 // Callback to call when pending request completes/fails. 94 // Callback to call when pending request completes/fails.
93 CompletionCallback completion_callback_; 95 CompletionCallback completion_callback_;
94 bool is_low_end_device_; 96 bool is_low_end_device_;
95 // ApplicationStatusListener to monitor if the Chrome moves to the foreground. 97 // ApplicationStatusListener to monitor if the Chrome moves to the foreground.
96 std::unique_ptr<base::android::ApplicationStatusListener> app_listener_; 98 std::unique_ptr<base::android::ApplicationStatusListener> app_listener_;
97 base::WeakPtrFactory<PrerenderingOffliner> weak_ptr_factory_; 99 base::WeakPtrFactory<PrerenderingOffliner> weak_ptr_factory_;
98 100
99 DISALLOW_COPY_AND_ASSIGN(PrerenderingOffliner); 101 DISALLOW_COPY_AND_ASSIGN(PrerenderingOffliner);
100 }; 102 };
101 103
102 } // namespace offline_pages 104 } // namespace offline_pages
103 105
104 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_ 106 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_OFFLINER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698