Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2715413002: LogDog: CLI can use stream URLs, fix auth. (Closed)

Created:
3 years, 9 months ago by dnj
Modified:
3 years, 9 months ago
Reviewers:
nodir, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: CLI can use stream URLs, fix auth. Enable the CLI to use LogDog stream URLs. Also, fix authentication parameters for default LogDog CLI app. BUG=chromium:694718 TEST=local R=nodir@chromium.org Review-Url: https://codereview.chromium.org/2715413002 Committed: https://github.com/luci/luci-go/commit/349a1604fc21905bc1e84b465beb0257fc2abe24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -56 lines) Patch
M logdog/client/cli/main.go View 7 chunks +38 lines, -18 lines 0 comments Download
M logdog/client/cli/subcommandCat.go View 6 chunks +43 lines, -21 lines 0 comments Download
M logdog/client/cli/subcommandLatest.go View 2 chunks +26 lines, -14 lines 0 comments Download
M logdog/client/cli/subcommandList.go View 3 chunks +8 lines, -1 line 0 comments Download
M logdog/client/cli/subcommandQuery.go View 3 chunks +8 lines, -1 line 0 comments Download
M logdog/client/cmd/logdog/main.go View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
dnj
3 years, 9 months ago (2017-02-27 23:08:07 UTC) #1
dnj
+hinoka@, if you have time :)
3 years, 9 months ago (2017-02-28 00:39:54 UTC) #3
dnj
pinggggggggggggggg
3 years, 9 months ago (2017-02-28 21:05:52 UTC) #4
nodir
lgtm
3 years, 9 months ago (2017-02-28 22:45:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715413002/1
3 years, 9 months ago (2017-02-28 22:47:13 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 22:53:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/349a1604fc21905bc1e84b465beb0257fc2abe24

Powered by Google App Engine
This is Rietveld 408576698