Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2715403002: Exposes the contents of math regions to screen readers (Closed)

Created:
3 years, 9 months ago by nektarios
Modified:
3 years, 9 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exposes the children of math regions. ARIA Implementation Guide 1.0 says that math should be mapped to ROLE_SYSTEM_EQUATION but we omitted to expose its children. Mac works fine ones AX_ROLE_MATH is removed from the list of leaf objects. Also checked with Safari and it does expose the children of role="math". BUG=645168 R=dmazzoni@chromium.org TESTED=manually Review-Url: https://codereview.chromium.org/2715403002 Cr-Commit-Position: refs/heads/master@{#455673} Committed: https://chromium.googlesource.com/chromium/src/+/54def8d1e3708b63e98e7db3a8e91554273b5561

Patch Set 1 #

Patch Set 2 : Reverted workaround. #

Patch Set 3 : Fixed test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M content/browser/accessibility/browser_accessibility.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-math-expected-mac.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-math-expected-win.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/html/math-expected-mac.txt View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/math-expected-win.txt View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
nektarios
3 years, 9 months ago (2017-02-27 23:04:17 UTC) #1
dmazzoni
lgtm
3 years, 9 months ago (2017-02-27 23:51:44 UTC) #4
nektarios
Ultimately, we should integrate with Jaws' and NVDA's math viewer.
3 years, 9 months ago (2017-02-27 23:54:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715403002/20001
3 years, 9 months ago (2017-03-09 03:05:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/381137)
3 years, 9 months ago (2017-03-09 03:42:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715403002/40001
3 years, 9 months ago (2017-03-09 04:24:03 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 05:25:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/54def8d1e3708b63e98e7db3a8e9...

Powered by Google App Engine
This is Rietveld 408576698