Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 27154004: Remove redundant attribute-to-event mappings in HTMLMediaElement (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove redundant attribute-to-event mappings in HTMLMediaElement See bug for why beforeload was left in. BUG=308047 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -44 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
philipj_slow
Will send mail to blink-dev about beforeload.
7 years, 2 months ago (2013-10-16 14:35:29 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
7 years, 2 months ago (2013-10-16 16:11:08 UTC) #2
adamk
lgtm
7 years, 2 months ago (2013-10-16 16:50:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/27154004/1
7 years, 2 months ago (2013-10-16 16:51:13 UTC) #4
philipj_slow
It looks like the trybots are going to try *everything*... Aaron, Adam, did either of ...
7 years, 2 months ago (2013-10-16 19:13:24 UTC) #5
adamk
On 2013/10/16 19:13:24, philipj wrote: > It looks like the trybots are going to try ...
7 years, 2 months ago (2013-10-16 19:24:24 UTC) #6
philipj_slow
On 2013/10/16 19:24:24, adamk wrote: > On 2013/10/16 19:13:24, philipj wrote: > > It looks ...
7 years, 2 months ago (2013-10-16 20:06:57 UTC) #7
philipj_slow
On 2013/10/16 19:24:24, adamk wrote: > On 2013/10/16 19:13:24, philipj wrote: > > It looks ...
7 years, 2 months ago (2013-10-16 20:06:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/27154004/1
7 years, 2 months ago (2013-10-16 20:39:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/27154004/1
7 years, 2 months ago (2013-10-17 01:33:05 UTC) #10
commit-bot: I haz the power
7 years, 2 months ago (2013-10-17 02:28:00 UTC) #11
Message was sent while issue was closed.
Change committed as 159813

Powered by Google App Engine
This is Rietveld 408576698