Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 27154004: Remove redundant attribute-to-event mappings in HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.cpp
diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
index 21942520fe4aeb31033a9899b054d37660d7f3c3..7da8f9d8f20540e7d3f6078a78f1e2c7168512c4 100644
--- a/Source/core/html/HTMLMediaElement.cpp
+++ b/Source/core/html/HTMLMediaElement.cpp
@@ -443,52 +443,8 @@ void HTMLMediaElement::parseAttribute(const QualifiedName& name, const AtomicStr
} else if (name == mediagroupAttr)
setMediaGroup(value);
- else if (name == onabortAttr)
- setAttributeEventListener(EventTypeNames::abort, createAttributeEventListener(this, name, value));
else if (name == onbeforeloadAttr)
setAttributeEventListener(EventTypeNames::beforeload, createAttributeEventListener(this, name, value));
- else if (name == oncanplayAttr)
- setAttributeEventListener(EventTypeNames::canplay, createAttributeEventListener(this, name, value));
- else if (name == oncanplaythroughAttr)
- setAttributeEventListener(EventTypeNames::canplaythrough, createAttributeEventListener(this, name, value));
- else if (name == ondurationchangeAttr)
- setAttributeEventListener(EventTypeNames::durationchange, createAttributeEventListener(this, name, value));
- else if (name == onemptiedAttr)
- setAttributeEventListener(EventTypeNames::emptied, createAttributeEventListener(this, name, value));
- else if (name == onendedAttr)
- setAttributeEventListener(EventTypeNames::ended, createAttributeEventListener(this, name, value));
- else if (name == onerrorAttr)
- setAttributeEventListener(EventTypeNames::error, createAttributeEventListener(this, name, value));
- else if (name == onloadeddataAttr)
- setAttributeEventListener(EventTypeNames::loadeddata, createAttributeEventListener(this, name, value));
- else if (name == onloadedmetadataAttr)
- setAttributeEventListener(EventTypeNames::loadedmetadata, createAttributeEventListener(this, name, value));
- else if (name == onloadstartAttr)
- setAttributeEventListener(EventTypeNames::loadstart, createAttributeEventListener(this, name, value));
- else if (name == onpauseAttr)
- setAttributeEventListener(EventTypeNames::pause, createAttributeEventListener(this, name, value));
- else if (name == onplayAttr)
- setAttributeEventListener(EventTypeNames::play, createAttributeEventListener(this, name, value));
- else if (name == onplayingAttr)
- setAttributeEventListener(EventTypeNames::playing, createAttributeEventListener(this, name, value));
- else if (name == onprogressAttr)
- setAttributeEventListener(EventTypeNames::progress, createAttributeEventListener(this, name, value));
- else if (name == onratechangeAttr)
- setAttributeEventListener(EventTypeNames::ratechange, createAttributeEventListener(this, name, value));
- else if (name == onseekedAttr)
- setAttributeEventListener(EventTypeNames::seeked, createAttributeEventListener(this, name, value));
- else if (name == onseekingAttr)
- setAttributeEventListener(EventTypeNames::seeking, createAttributeEventListener(this, name, value));
- else if (name == onstalledAttr)
- setAttributeEventListener(EventTypeNames::stalled, createAttributeEventListener(this, name, value));
- else if (name == onsuspendAttr)
- setAttributeEventListener(EventTypeNames::suspend, createAttributeEventListener(this, name, value));
- else if (name == ontimeupdateAttr)
- setAttributeEventListener(EventTypeNames::timeupdate, createAttributeEventListener(this, name, value));
- else if (name == onvolumechangeAttr)
- setAttributeEventListener(EventTypeNames::volumechange, createAttributeEventListener(this, name, value));
- else if (name == onwaitingAttr)
- setAttributeEventListener(EventTypeNames::waiting, createAttributeEventListener(this, name, value));
else
HTMLElement::parseAttribute(name, value);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698